Re: Should legacy fstat (via __fxstat) and fstat@GLIBC_2.33 call the same syscall?

[Florian Weimer <fweimer@redhat.com>]

* Adhemerval Zanella:

> This is a spreadsheet with various supported architectures for the xstat
> implementation prior the consolidation and the requirements for each
> syscall and/or transformation required [1].

[1] https://docs.google.com/spreadsheets/d/e/2PACX-1vRG3-1W8roNgHXVaY8zqIBlGqCRtztdyDUvS_VLLkCnmXANYTmZZvONda6TAKcNSNsqfswMn1_IadE5/pubhtml

> It is quite a mess and that's why I think making only fstatat64 the one
> with the syscall logic does simplify a lot.

I still don't get why this wouldn't be a desirable change:

--- a/sysdeps/unix/sysv/linux/fxstat.c
+++ b/sysdeps/unix/sysv/linux/fxstat.c
@@ -35,18 +35,7 @@ __fxstat (int vers, int fd, struct stat *buf)
   switch (vers)
     {
     case _STAT_VER_KERNEL:
-      {
-# if STAT_IS_KERNEL_STAT
-	/* New kABIs which uses generic pre 64-bit time Linux ABI,
-	   e.g. csky, nios2  */
-	int r = INLINE_SYSCALL_CALL (fstat64, fd, buf);
-	return r ?: stat_overflow (buf);
-# else
-	/* Old kABIs with old non-LFS support, e.g. arm, i386, hppa, m68k,
-	   microblaze, s390, sh, powerpc, and sparc.  */
-	return INLINE_SYSCALL_CALL (fstat, fd, buf);
-# endif
-      }
+      return fstat (fd, buf);
 
     default:
       {

Thanks,
Florian
-- 
Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill