[PATCH] Add xfchmod to libsupport

[PATCH] Add xfchmod to libsupport

[Alexandra Hájková]

From: Alexandra Hájková <ahajkova@redhat.com>

---

This patch  is needed for my pending execveat syscall wrapper patch.

 support/Makefile  |  1 +
 support/xfchmod.c | 28 ++++++++++++++++++++++++++++
 support/xunistd.h |  1 +
 3 files changed, 30 insertions(+)
 create mode 100644 support/xfchmod.c

diff --git a/support/Makefile b/support/Makefile
index 26e4ab1c4c..94a88bf819 100644
--- a/support/Makefile
+++ b/support/Makefile
@@ -97,6 +97,7 @@ libsupport-routines = \
   xdlmopen \
   xdup2 \
   xfclose \
+  xfchmod \
   xfopen \
   xfork \
   xftruncate \
diff --git a/support/xfchmod.c b/support/xfchmod.c
new file mode 100644
index 0000000000..4a6daa99e2
--- /dev/null
+++ b/support/xfchmod.c
@@ -0,0 +1,28 @@
+/* fchmod with error checking.
+   Copyright (C) 2020 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <https://www.gnu.org/licenses/>.  */
+
+#include <support/check.h>
+#include <support/xunistd.h>
+#include <sys/stat.h>
+
+void
+xfchmod (int fd, mode_t mode)
+{
+  if (fchmod (fd, mode) != 0)
+    FAIL_EXIT1 ("mkdir (\"%d\", 0%o): %m", fd, mode);
+}
diff --git a/support/xunistd.h b/support/xunistd.h
index c4b7aa01c9..dcccf78372 100644
--- a/support/xunistd.h
+++ b/support/xunistd.h
@@ -46,6 +46,7 @@ long long xlseek (int fd, long long offset, int whence);
 void xftruncate (int fd, long long length);
 void xsymlink (const char *target, const char *linkpath);
 void xchdir (const char *path);
+void xfchmod (int fd, mode_t mode);
 
 /* Equivalent of "mkdir -p".  */
 void xmkdirp (const char *, mode_t);
-- 
2.26.2

Re: [PATCH] Add xfchmod to libsupport

[Florian Weimer]

* Alexandra Hájková via Libc-alpha:

> diff --git a/support/xfchmod.c b/support/xfchmod.c
> new file mode 100644
> index 0000000000..4a6daa99e2
> --- /dev/null
> +++ b/support/xfchmod.c
> @@ -0,0 +1,28 @@
> +/* fchmod with error checking.
> +   Copyright (C) 2020 Free Software Foundation, Inc.

The copyright year needs to be 2021 now.

> +xfchmod (int fd, mode_t mode)
> +{
> +  if (fchmod (fd, mode) != 0)
> +    FAIL_EXIT1 ("mkdir (\"%d\", 0%o): %m", fd, mode);
> +}

Please fix the function name (should be "fchmod", not "mkdir"), and
remove the quotes around %d.  Rest looks fine.

[PATCH] Add xfchmod to libsupport

[Alexandra Hájková]

From: Alexandra Hájková <ahajkova@redhat.com>

---
 support/Makefile  |  1 +
 support/xfchmod.c | 28 ++++++++++++++++++++++++++++
 support/xunistd.h |  1 +
 3 files changed, 30 insertions(+)
 create mode 100644 support/xfchmod.c

diff --git a/support/Makefile b/support/Makefile
index f4d157dded..fce5c9cd4a 100644
--- a/support/Makefile
+++ b/support/Makefile
@@ -97,6 +97,7 @@ libsupport-routines = \
   xdlmopen \
   xdup2 \
   xfclose \
+  xfchmod \
   xfopen \
   xfork \
   xftruncate \
diff --git a/support/xfchmod.c b/support/xfchmod.c
new file mode 100644
index 0000000000..4323b9ca8e
--- /dev/null
+++ b/support/xfchmod.c
@@ -0,0 +1,28 @@
+/* fchmod with error checking.
+   Copyright (C) 2021 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <https://www.gnu.org/licenses/>.  */
+
+#include <support/check.h>
+#include <support/xunistd.h>
+#include <sys/stat.h>
+
+void
+xfchmod (int fd, mode_t mode)
+{
+  if (fchmod (fd, mode) != 0)
+    FAIL_EXIT1 ("fchmod (%d, 0%o): %m", fd, mode);
+}
diff --git a/support/xunistd.h b/support/xunistd.h
index 12a5ab677c..eb1b5519ff 100644
--- a/support/xunistd.h
+++ b/support/xunistd.h
@@ -46,6 +46,7 @@ long long xlseek (int fd, long long offset, int whence);
 void xftruncate (int fd, long long length);
 void xsymlink (const char *target, const char *linkpath);
 void xchdir (const char *path);
+void xfchmod (int fd, mode_t mode);
 
 /* Equivalent of "mkdir -p".  */
 void xmkdirp (const char *, mode_t);
-- 
2.26.2

Re: [PATCH] Add xfchmod to libsupport

[Florian Weimer]

* Alexandra Hájková via Libc-alpha:

> diff --git a/support/Makefile b/support/Makefile
> index f4d157dded..fce5c9cd4a 100644
> --- a/support/Makefile
> +++ b/support/Makefile
> @@ -97,6 +97,7 @@ libsupport-routines = \
>    xdlmopen \
>    xdup2 \
>    xfclose \
> +  xfchmod \
>    xfopen \
>    xfork \
>    xftruncate \

Please keep the list in ASCII order.  Otherwise, this version looks
fine to me, you should push it after sapping xfchmod and xfclose.