From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 09DAF387089E for ; Tue, 29 Sep 2020 17:05:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 09DAF387089E Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-441-wH_O9i4yPB2DmOTX3lwxXg-1; Tue, 29 Sep 2020 13:05:31 -0400 X-MC-Unique: wH_O9i4yPB2DmOTX3lwxXg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 09CF9802B7A; Tue, 29 Sep 2020 17:05:30 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-114-84.ams2.redhat.com [10.36.114.84]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B62065D9CA; Tue, 29 Sep 2020 17:05:28 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: Adhemerval Zanella via Libc-alpha , Robert O'Callahan , "Dmitry V . Levin" Subject: Re: [PATCH 4/6] sysvipc: Return EINVAL for invalid msgctl commands References: <20200928144556.239160-1-adhemerval.zanella@linaro.org> <20200928144556.239160-4-adhemerval.zanella@linaro.org> <877dsdypxj.fsf@oldenburg2.str.redhat.com> <3dcdc1fd-e3d2-9e30-ff86-4a2eb5fff050@linaro.org> Date: Tue, 29 Sep 2020 19:05:26 +0200 In-Reply-To: <3dcdc1fd-e3d2-9e30-ff86-4a2eb5fff050@linaro.org> (Adhemerval Zanella's message of "Tue, 29 Sep 2020 10:26:09 -0300") Message-ID: <87imbwwm21.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Sep 2020 17:05:36 -0000 * Adhemerval Zanella: > On 29/09/2020 04:58, Florian Weimer wrote: >> * Adhemerval Zanella via Libc-alpha: >> >>> It avoids regressions on possible future commands that might require >>> additional libc support. The downside is new commands added by newer >>> kernels will need further glibc support. >> >> Looks okay to me for now. >> >> I think eventually we need to rethink what we want to do about these, >> for the architectures that don't need translation. > > We already have __IPC_TIME64 to tell apart the ABI that require it, > we might to put the switch only if it is set. However, I am not sure > if it is really an improvement, since we will still need to revise > it for architecture with __IPC_TIME64 == 1 anyway. It's an improvement for users on architectures which can use this facility. I think we should not artificially hold back architectures with full userspace/kernel alignment just because there are other architectures out there which are more complicated. Thanks, Florian -- Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill