From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id C76F63857C5E for ; Mon, 21 Sep 2020 08:21:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C76F63857C5E Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-534-etIkOCuBPciqv_t6Y0LdMQ-1; Mon, 21 Sep 2020 04:21:33 -0400 X-MC-Unique: etIkOCuBPciqv_t6Y0LdMQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5CF74807340; Mon, 21 Sep 2020 08:21:32 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-114-108.ams2.redhat.com [10.36.114.108]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A952A68D5F; Mon, 21 Sep 2020 08:21:31 +0000 (UTC) From: Florian Weimer To: "H.J. Lu" Cc: "H.J. Lu via Libc-alpha" Subject: Re: [PATCH 1/3] x86: Initialize CPU info via IFUNC relocation [BZ 26203] References: <20200912134441.2407884-1-hjl.tools@gmail.com> <20200912134441.2407884-2-hjl.tools@gmail.com> <874knva4r6.fsf@oldenburg2.str.redhat.com> <87a6xn6v8u.fsf@oldenburg2.str.redhat.com> <87y2l75fls.fsf@oldenburg2.str.redhat.com> Date: Mon, 21 Sep 2020 10:21:30 +0200 In-Reply-To: (H. J. Lu's message of "Fri, 18 Sep 2020 07:30:16 -0700") Message-ID: <87imc78rqt.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, URIBL_BLACK autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Sep 2020 08:21:40 -0000 * H. J. Lu: >> Putting this data into _rtld_global_ro is not correct if it is required >> after static dlopen. The current static dlopen approach simply does not >> support that. You can only assume that libc.so has been initialized >> after static dlopen. > Unless it is removed, _rtld_global_ro is the right place. _rtld_global_ro > is initialized by dynamic relocation. My patch does it. It initializes only part of it. I find this rather confusing. Why is this data in ld.so in the first place? Thanks, Florian -- Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill