From: Andreas Schwab <schwab@linux-m68k.org>
To: DJ Delorie via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [patch] Use unsigned constants for ICMP6 filters [BZ #22489]
Date: Sat, 25 Apr 2020 10:53:16 +0200 [thread overview]
Message-ID: <87imhondz7.fsf@linux-m68k.org> (raw)
In-Reply-To: <xn1rocbm9h.fsf@greed.delorie.com> (DJ Delorie via Libc-alpha's message of "Fri, 24 Apr 2020 17:35:06 -0400")
On Apr 24 2020, DJ Delorie via Libc-alpha wrote:
> The core problem here is that the bitfields are unsigned but
> the computed constants are signed. This patch forces the computed
> constants to be unsigned. - DJ
That explanation doesn't make sense. This has nothing to do with
signedness of bitfields, it is about shifting a value out of its range.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2020-04-25 8:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 21:35 DJ Delorie
2020-04-25 8:53 ` Andreas Schwab [this message]
2020-04-25 17:15 ` DJ Delorie
2020-04-25 17:48 ` Andreas Schwab
2020-04-25 21:23 ` DJ Delorie
2020-04-25 21:30 ` Andreas Schwab
2020-04-25 21:41 ` DJ Delorie
2020-04-26 11:25 ` Alexander Monakov
2020-04-26 11:56 ` Florian Weimer
2020-04-30 20:47 ` DJ Delorie
2020-05-03 20:23 ` Florian Weimer
2020-05-08 20:10 ` DJ Delorie
2020-05-08 20:22 ` Florian Weimer
2020-05-11 21:09 ` DJ Delorie
2020-05-12 7:35 ` Andreas Schwab
2020-04-26 8:03 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imhondz7.fsf@linux-m68k.org \
--to=schwab@linux-m68k.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).