From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by sourceware.org (Postfix) with ESMTPS id E5483385DC1C for ; Sat, 25 Apr 2020 08:53:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E5483385DC1C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=whitebox@nefkom.net Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 498Pvf2W1tz1qsjg; Sat, 25 Apr 2020 10:53:18 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 498Pvf277zz1qrWs; Sat, 25 Apr 2020 10:53:18 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id fkz-MXdIC-7K; Sat, 25 Apr 2020 10:53:17 +0200 (CEST) X-Auth-Info: IbFoI3OjgEwzuNKvvDRAOOVunrqft7Hc8DT8iqnDH4e9hptWCRMELbPzG+wVX0Vm Received: from hase.home (ppp-46-244-168-90.dynamic.mnet-online.de [46.244.168.90]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Sat, 25 Apr 2020 10:53:17 +0200 (CEST) Received: by hase.home (Postfix, from userid 1000) id BA1E9102507; Sat, 25 Apr 2020 10:53:16 +0200 (CEST) From: Andreas Schwab To: DJ Delorie via Libc-alpha Subject: Re: [patch] Use unsigned constants for ICMP6 filters [BZ #22489] References: X-Yow: Are we live or on tape? Date: Sat, 25 Apr 2020 10:53:16 +0200 In-Reply-To: (DJ Delorie via Libc-alpha's message of "Fri, 24 Apr 2020 17:35:06 -0400") Message-ID: <87imhondz7.fsf@linux-m68k.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Apr 2020 08:53:23 -0000 On Apr 24 2020, DJ Delorie via Libc-alpha wrote: > The core problem here is that the bitfields are unsigned but > the computed constants are signed. This patch forces the computed > constants to be unsigned. - DJ That explanation doesn't make sense. This has nothing to do with signedness of bitfields, it is about shifting a value out of its range. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."