From: Florian Weimer <fweimer@redhat.com>
To: Petr Vorel <pvorel@suse.cz>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] <dirent.h>: Remove wrong comment about getdents64() declaration
Date: Mon, 07 Oct 2019 13:12:00 -0000 [thread overview]
Message-ID: <87imp0lmxw.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <20191007130749.29272-1-pvorel@suse.cz> (Petr Vorel's message of "Mon, 7 Oct 2019 15:07:49 +0200")
* Petr Vorel:
> Originally the public interface for getdents64 was declared in
> <unistd.h> in 51ea67d548. Later, b8b3d5a14e moved it to <dirent.h>.
>
> Fixes: b8b3d5a14e ("Linux: Move getdents64 to <dirent.h>")
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> include/dirent.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/dirent.h b/include/dirent.h
> index 3736803bce..1f0121f3d9 100644
> --- a/include/dirent.h
> +++ b/include/dirent.h
> @@ -36,8 +36,7 @@ extern __ssize_t __getdirentries (int __fd, char *__restrict __buf,
> __off_t *__restrict __basep)
> __THROW __nonnull ((2, 4));
>
> -/* These functions are only implemented on Linux. The public
> - interface for getdents64 is declared in <unistd.h>. */
> +/* These functions are only implemented on Linux. */
> extern __ssize_t __getdents (int __fd, void *__buf, size_t __nbytes)
> attribute_hidden;
> extern __ssize_t __getdents64 (int __fd, void *__buf, size_t __nbytes);
Looks good to me, thanks. I assume you don't have commit access. I can
install the patch for you.
Florian
next prev parent reply other threads:[~2019-10-07 13:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 13:07 Petr Vorel
2019-10-07 13:12 ` Florian Weimer [this message]
2019-10-07 13:16 ` Petr Vorel
2019-10-09 9:32 ` Florian Weimer
2019-10-09 12:19 ` Petr Vorel
2019-10-09 12:22 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imp0lmxw.fsf@oldenburg2.str.redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).