From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58439 invoked by alias); 18 Nov 2016 00:21:05 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 58412 invoked by uid 89); 18 Nov 2016 00:21:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_NEUTRAL autolearn=ham version=3.3.2 spammy= X-HELO: sinikuusama2.dnainternet.net X-Spam-Score: 0.652 From: Kalle Olavi Niemitalo To: libc-alpha Subject: Re: [PATCH 2/2] New internal function __access_noerrno In-Reply-To: (Adhemerval Zanella's message of "Thu, 17 Nov 2016 19:30:38 -0200") References: <1478797446-12213-1-git-send-email-adhemerval.zanella@linaro.org> <1478797446-12213-2-git-send-email-adhemerval.zanella@linaro.org> <083c6da8-5c67-acba-f7f0-79fb4253d7d2@gotplt.org> <23ef1354-7ade-70fe-46f0-59392798ef82@linaro.org> <60199742-d6f4-3f2a-ad38-619dcfdc7954@linaro.org> <87r369j093.fsf@Niukka.kon.iki.fi> User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.51 (gnu/linux) Keywords: Hurd,errno Date: Fri, 18 Nov 2016 00:21:00 -0000 Message-ID: <87inrliqmx.fsf@Niukka.kon.iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2016-11/txt/msg00646.txt.bz2 Adhemerval Zanella writes: > Below is all the fixes you proposed, if you think it is ok I will > prepare a patch and commit. Thanks. It looks like an improvement. I'd like to do some testing during the weekend. However, I suspect that this __access_noerrno may be unsafe to run during initialization of tunables on the Hurd. access_common calls __hurd_file_name_lookup, which calls __hurd_file_name_lookup_retry, which can use errno, __strtoul_internal, _itoa, strcpy, and memcmp. I'm not yet sure whether this is a problem, and I'm not asking you to spend time on it.