From: Florian Weimer <fweimer@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] elf: Properly remove the initial 'env' command
Date: Fri, 09 Feb 2024 14:00:40 +0100 [thread overview]
Message-ID: <87jznd7pxj.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20240209125449.2352780-1-hjl.tools@gmail.com> (H. J. Lu's message of "Fri, 9 Feb 2024 04:54:49 -0800")
* H. J. Lu:
> index 9e70e74bf8..dfba94de64 100644
> --- a/elf/tst-rtld-list-diagnostics.py
> +++ b/elf/tst-rtld-list-diagnostics.py
> @@ -294,7 +294,11 @@ def main(argv):
> check_consistency_with_manual(opts.manual)
>
> # Remove the initial 'env' command.
> - parse_diagnostics(opts.command.split()[1:])
> + options = []
> + for o in opts.command.split()[0:]:
> + if o != 'env':
> + options.append(o)
> + parse_diagnostics(options)
I think you can write this as:
options = opts.command.split()[:]
options.remove('env')
It only removes the first occurrence, but I think that is more correct
anyway.
Thanks,
Florian
next prev parent reply other threads:[~2024-02-09 13:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 12:54 H.J. Lu
2024-02-09 13:00 ` Florian Weimer [this message]
2024-02-09 13:19 ` H.J. Lu
2024-02-09 13:16 ` Andreas Schwab
2024-02-09 13:30 ` Florian Weimer
2024-02-09 13:52 ` H.J. Lu
2024-02-09 14:53 ` Florian Weimer
2024-02-09 15:00 ` H.J. Lu
2024-02-09 15:17 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jznd7pxj.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).