From: Florian Weimer <fweimer@redhat.com>
To: Siddhesh Poyarekar <siddhesh@gotplt.org>
Cc: "Adhemerval Zanella" <adhemerval.zanella@linaro.org>,
libc-alpha@sourceware.org, "Frederic Berat" <fberat@redhat.com>,
"Andreas K. Hüttel" <dilfridge@gentoo.org>
Subject: Re: [PATCH] scripts: Fix fortify checks if compiler does not support _FORTIFY_SOURCE=3
Date: Thu, 20 Jul 2023 18:26:53 +0200 [thread overview]
Message-ID: <87jzuumtv6.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <3c50256e-863d-bd66-d36a-fb1e23cbfbda@gotplt.org> (Siddhesh Poyarekar's message of "Thu, 20 Jul 2023 12:22:38 -0400")
* Siddhesh Poyarekar:
> On 2023-07-20 10:40, Adhemerval Zanella via Libc-alpha wrote:
>> The 30379efad1 added _FORTIFY_SOURCE checks without check if compiler
>> does support all used fortify levels. This patch fixes it by first
>> checking at configure time the maximum support fortify level and using
>> it instead of a pre-defined one.
>> Checked on x86_64 with gcc 11, 12, and 13.
>> ---
>
> LGTM, pending approval from RM. At the moment there's no real reason
> to verify headers for different fortification levels (just 1 or 2
> would do) but I reckon it's a future-proof change, in case we ever end
> up diverging further on those levels.
>
> Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
Agreed, and (with GCC 11):
Tested-by: Florian Weimer <fweimer@redhat.com>
Thanks,
Florian
next prev parent reply other threads:[~2023-07-20 16:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 14:40 Adhemerval Zanella
2023-07-20 16:22 ` Siddhesh Poyarekar
2023-07-20 16:26 ` Florian Weimer [this message]
2023-07-20 16:46 ` Andreas K. Huettel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzuumtv6.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=dilfridge@gentoo.org \
--cc=fberat@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@gotplt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).