From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=xBen=BT=redhat.com=fweimer@sourceware.org>
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
	by sourceware.org (Postfix) with ESMTPS id 51BDE3858D28
	for <libc-alpha@sourceware.org>; Tue, 30 May 2023 12:24:12 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 51BDE3858D28
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1685449452;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=PSHoGTQT0oM/zRSed5aa+HNAyS/3fCAiufvtPLKJvt4=;
	b=bkbebw9WtXe+CPL542T8FY2jX2ikvygBetpYi09S3JIx2OuvdswqNFfy3P/BdCZVlfn4eC
	kywxCV6Ip/oGhZ2I58GztL/oSwN/bUCpcYpum7CykHRWTpXwaPS3QoQqwH51BO5nfKO9LI
	V5K/gOzeg3GF7RKPlYBBvdBHJs4yu40=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-194-prySAy_YOey4Mukzn4-P4A-1; Tue, 30 May 2023 08:20:58 -0400
X-MC-Unique: prySAy_YOey4Mukzn4-P4A-1
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7882E8030D0;
	Tue, 30 May 2023 12:20:58 +0000 (UTC)
Received: from oldenburg.str.redhat.com (unknown [10.2.16.38])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 6EBC940CFD46;
	Tue, 30 May 2023 12:20:57 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: Carlos O'Donell <carlos@redhat.com>
Cc: libc-alpha@sourceware.org,  alx.manpages@gmail.com
Subject: Re: [PATCH v2 1/2] elf: Sort Makefile variables.
References: <20230530120759.2150593-1-carlos@redhat.com>
Date: Tue, 30 May 2023 14:20:55 +0200
In-Reply-To: <20230530120759.2150593-1-carlos@redhat.com> (Carlos O'Donell's
	message of "Tue, 30 May 2023 08:07:58 -0400")
Message-ID: <87jzwqt3h4.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

* Carlos O'Donell:

> Sort Makefile variables using scrips/sort-makefile-lines.py.
>
> No code generation changes observed in non-test binary artifacts.
> No regressions on x86_64 and i686.
> ---
>  elf/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/elf/Makefile b/elf/Makefile
> index 3bfc305d98..c00e2ccfc5 100644
> --- a/elf/Makefile
> +++ b/elf/Makefile
> @@ -274,8 +274,8 @@ tests-static-normal := \
>    # tests-static-normal
>  
>  tests-static-internal := \
> -  tst-dl_find_object-static \
>    tst-dl-printf-static \
> +  tst-dl_find_object-static \
>    tst-ptrguard1-static \
>    tst-stackguard1-static \
>    tst-tls1-static \

Okay,

Reviewed-by: Florian Weimer <fweimer@redhat.com>

Thanks,
Florian