From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id C50B73858D28 for ; Fri, 19 May 2023 12:25:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C50B73858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684499156; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BWnzoFJ45ZtjfQQyakW996ipYh6jW4/BUWwwCLr2F7M=; b=Bizxo2nUOtg9TS8S4H9H+Pp9n1X8l7MeD3kHHi4Otd8dzSdpabLrSfqPN8cSGjdVDTl6N2 sJWmgyu3bHkjgR4WJn2tp3Jso4dmxDW01eBtXxFJVrmDTdDiGVx+rS7jdB60CyVJwOgZAr /WacPZsgq5l5oj3PzGlAx8edXPKCC1o= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-339-LFXbXlQsMmScRb85xzqsuw-1; Fri, 19 May 2023 08:25:55 -0400 X-MC-Unique: LFXbXlQsMmScRb85xzqsuw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0BE913C17A6B; Fri, 19 May 2023 12:25:55 +0000 (UTC) Received: from oldenburg3.str.redhat.com (unknown [10.39.192.229]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5E5AC7B7C; Fri, 19 May 2023 12:25:53 +0000 (UTC) From: Florian Weimer To: Sergey Bugaev via Libc-alpha Cc: bug-hurd@gnu.org, Sergey Bugaev Subject: Re: [RFC PATCH 1/2] elf: Port ldconfig away from stack-allocated paths References: <20230517185422.71084-1-bugaevc@gmail.com> <20230517185422.71084-2-bugaevc@gmail.com> Date: Fri, 19 May 2023 14:25:52 +0200 In-Reply-To: <20230517185422.71084-2-bugaevc@gmail.com> (Sergey Bugaev via Libc-alpha's message of "Wed, 17 May 2023 21:54:21 +0300") Message-ID: <87jzx4jynj.fsf@oldenburg3.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Sergey Bugaev via Libc-alpha: > @@ -733,25 +723,11 @@ search_dir (const struct dir_entry *entry) > + 1, ".#prelink#.", sizeof (".#prelink#.") - 1) == 0) > continue; > } > - len += strlen (entry->path) + 2; > - if (len > file_name_len) > - { > - file_name_len = len; > - file_name = alloca (file_name_len); > - if (!opt_chroot) > - real_file_name = file_name; > - } > - sprintf (file_name, "%s/%s", entry->path, direntry->d_name); > + asprintf (&file_name, "%s/%s", entry->path, direntry->d_name); > if (opt_chroot != NULL) > - { > - len = strlen (dir_name) + strlen (direntry->d_name) + 2; > - if (len > real_file_name_len) > - { > - real_file_name_len = len; > - real_file_name = alloca (real_file_name_len); > - } > - sprintf (real_file_name, "%s/%s", dir_name, direntry->d_name); > - } > + asprintf (&real_file_name, "%s/%s", dir_name, direntry->d_name); > + else > + real_file_name = file_name; > > struct stat lstat_buf; > /* We optimize and try to do the lstat call only if needed. */ Missing error checking? I think we use x* functions such a xstrdup elsewhere in ldconfig, so you could add xasprintf as well. Thanks, Florian