From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 21BB138485A8 for ; Mon, 23 May 2022 06:39:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 21BB138485A8 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-477-JfDN6Q0fO_mpBn9IDN6p3A-1; Mon, 23 May 2022 02:39:27 -0400 X-MC-Unique: JfDN6Q0fO_mpBn9IDN6p3A-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1790C1C05EAA; Mon, 23 May 2022 06:39:27 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.91]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 40453492C3B; Mon, 23 May 2022 06:39:26 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 04/26] stdio-common: Add tst-printf-width-i18n to cover numeric field width References: <46cd3655-331d-efb1-89c9-db9fd9a66827@linaro.org> <90fbdc02-7579-30d0-88ae-e1ac3feb94d2@linaro.org> Date: Mon, 23 May 2022 08:39:24 +0200 In-Reply-To: <90fbdc02-7579-30d0-88ae-e1ac3feb94d2@linaro.org> (Adhemerval Zanella's message of "Fri, 20 May 2022 10:33:53 -0300") Message-ID: <87k0aczrab.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 May 2022 06:39:32 -0000 * Adhemerval Zanella: > On 20/05/2022 10:22, Adhemerval Zanella wrote: >> >> >> On 17/03/2022 16:28, Florian Weimer via Libc-alpha wrote: >>> Related to bug 28943 and bug 28944. >> >> LGTM with the fix to enabled the test. >> >> Reviewed-by: Adhemerval Zanella >> >>> --- >>> stdio-common/Makefile | 1 + >>> stdio-common/tst-printf-width-i18n.c | 95 ++++++++++++++++++++++++++++ >>> 2 files changed, 96 insertions(+) >>> create mode 100644 stdio-common/tst-printf-width-i18n.c >>> >>> diff --git a/stdio-common/Makefile b/stdio-common/Makefile >>> index 435cd8904f..f0e65f0dcd 100644 >>> --- a/stdio-common/Makefile >>> +++ b/stdio-common/Makefile >>> @@ -250,6 +250,7 @@ LOCALES := \ >>> de_DE.ISO-8859-1 \ >>> de_DE.UTF-8 \ >>> en_US.ISO-8859-1 \ >>> + hi_IN.UTF-8 \ >>> ja_JP.EUC-JP \ >>> ps_AF.UTF-8 \ >>> # LOCALES >> >> The tests is not enabled since there is no entry in tests. > > And you will also need to add a rule to avoid the test fail in parallel builds: > > $(objpfx)/tst-printf-width-i18n.out: $(gen-locales) Right, fixed both and renamed the test to tst-vfprintf-width-i18n, to be consistent with the other tests. Thanks, Florian