public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] stdio-common: Add the fgetln function
Date: Tue, 03 May 2022 11:01:08 +0200	[thread overview]
Message-ID: <87k0b3vvl7.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <87a6bzf1gu.fsf@igel.home> (Andreas Schwab's message of "Tue, 03 May 2022 10:46:09 +0200")

* Andreas Schwab:

> On Mai 03 2022, Florian Weimer wrote:
>
>> * Andreas Schwab:
>>
>>> On Mai 03 2022, Florian Weimer via Libc-alpha wrote:
>>>
>>>> +/* Reads the next line from STREAM and returns a pointer to the start of
>>>       Read                                return
>>>
>>>> +   an array containing it.  The array is not null-terminated.  The
>>>
>>> That makes it a rather clunky interface.  Why do we need that, given
>>> getline et al?
>>
>> Unfortunately, some software uses this function.
>
> getline is standard.

I think we should provide this function to avoid the bugs I outlined.

Thanks,
Florian


  reply	other threads:[~2022-05-03  9:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-03  7:36 Florian Weimer
2022-05-03  8:06 ` Andreas Schwab
2022-05-03  8:31   ` Florian Weimer
2022-05-03  8:46     ` Andreas Schwab
2022-05-03  9:01       ` Florian Weimer [this message]
2022-05-03  9:10         ` Andreas Schwab
2022-05-03 10:45         ` Cristian Rodríguez
2022-05-04  0:40 ` Paul Eggert
2022-06-09  7:37   ` Florian Weimer
2022-06-09 20:08     ` Paul Eggert
2022-06-24 11:01       ` Florian Weimer
2022-06-24 20:35         ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k0b3vvl7.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).