From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 2231D3858C74 for ; Tue, 1 Feb 2022 12:06:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2231D3858C74 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-512-mSQ2ND66NByDurn86x-FWA-1; Tue, 01 Feb 2022 07:06:01 -0500 X-MC-Unique: mSQ2ND66NByDurn86x-FWA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8203F84DA41; Tue, 1 Feb 2022 12:06:00 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.193.205]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6F5C76F95E; Tue, 1 Feb 2022 12:05:46 +0000 (UTC) From: Florian Weimer To: Carlos O'Donell Cc: libc-alpha@sourceware.org, michael.hudson@canonical.com Subject: Re: [PATCH 2/2] localedata: Adjust C.UTF-8 to align with C/POSIX. References: <20220131053442.3995804-1-carlos@redhat.com> <20220131053442.3995804-3-carlos@redhat.com> Date: Tue, 01 Feb 2022 13:05:44 +0100 In-Reply-To: <20220131053442.3995804-3-carlos@redhat.com> (Carlos O'Donell's message of "Mon, 31 Jan 2022 00:34:42 -0500") Message-ID: <87k0ee4wrr.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Feb 2022 12:06:10 -0000 * Carlos O'Donell: > We have had one downstream report from Canonical [1] that > an rrdtool test was broken by the differences in LC_TIME > that we had in the non-builtin C locale (C.UTF-8). If one > application has an issue there are going to be others, and > so with this commit we review and fix all the issues that > cause the builtin C locale to be different from C.UTF-8, > which includes: > * mon_decimal_point should be empty e.g. "" > - Depends on mon_decimal_point_wc fix. > * negative_sign should be empty e.g. "" > * week should be aligned with ISO 30112 default e.g. 7;19971130;4 > * d_fmt corrected with escaped slashes e.g. "%m//%d//%y" > * yesstr and nostr should be empty e.g. "" > * country_ab2 and country_ab3 should be empty e.g. "" > > We bump LC_IDENTIFICATION version and adjust the date to > indicate the change in the locale. > > A new tst-c-utf8-consistency test is added to ensure > consistency between C/POSIX and C.UTF-8. > > Tested on x86_64 and i686 without regression. > > [1] https://sourceware.org/pipermail/libc-alpha/2022-January/135703.html > > Co-authored-by: Florian Weimer > --- > localedata/Makefile | 30 +- > localedata/locales/C | 22 +- > localedata/tst-c-utf8-consistency.c | 539 ++++++++++++++++++++++++++++ > 3 files changed, 578 insertions(+), 13 deletions(-) > create mode 100644 localedata/tst-c-utf8-consistency.c This looks broadly okay to me. Dropping the ISO standard reference seems prudent if we can't check its contents. Reviewed-by: Florian Weimer Thanks, Florian