From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id A113D3858C27 for ; Fri, 24 Dec 2021 17:44:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A113D3858C27 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-632-yI77XPzwNzmRVRboKYZCdQ-1; Fri, 24 Dec 2021 12:44:22 -0500 X-MC-Unique: yI77XPzwNzmRVRboKYZCdQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0E1B093921; Fri, 24 Dec 2021 17:44:21 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.104]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A9E135F92E; Fri, 24 Dec 2021 17:44:19 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, John Mellor-Crummey , Ben Woodard Subject: Re: [PATCH v7 13/16] elf: Issue audit la_objopen for vDSO References: <20211222132712.523295-1-adhemerval.zanella@linaro.org> <20211222132712.523295-14-adhemerval.zanella@linaro.org> Date: Fri, 24 Dec 2021 18:44:17 +0100 In-Reply-To: <20211222132712.523295-14-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Wed, 22 Dec 2021 10:27:09 -0300") Message-ID: <87k0ft99u6.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Dec 2021 17:44:26 -0000 * Adhemerval Zanella: > The vDSO is is listed in the link_map chain, but is never the subject of > an la_objopen call. A new internal flag __RTLD_VDSO is added that > acts as __RTLD_OPENEXEC to allocate the required 'struct auditstate' > extra space for the 'struct link_map'. > > The return value from the callback is currently ignored, since there > is no PLT call involved by glibc when using the vDSO, neither the vDSO > are exported directly. > > Checked on x86_64-linux-gnu, i686-linux-gnu, and aarch64-linux-gnu. > --- > elf/Makefile | 5 ++ > elf/dl-object.c | 17 +++--- > elf/rtld.c | 6 +++ > elf/setup-vdso.h | 2 +- > elf/tst-audit22.c | 124 +++++++++++++++++++++++++++++++++++++++++++ > elf/tst-auditmod22.c | 51 ++++++++++++++++++ > include/dlfcn.h | 2 + > 7 files changed, 199 insertions(+), 8 deletions(-) > create mode 100644 elf/tst-audit22.c > create mode 100644 elf/tst-auditmod22.c This version looks good to me. Reviewed-by: Florian Weimer Thanks, Florian