From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 395C4383B80E for ; Mon, 21 Jun 2021 07:06:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 395C4383B80E Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-249-VqZwHxk5MT-G1eSzqw9VpA-1; Mon, 21 Jun 2021 03:06:07 -0400 X-MC-Unique: VqZwHxk5MT-G1eSzqw9VpA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 35C8A100C609; Mon, 21 Jun 2021 07:06:06 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-115-60.ams2.redhat.com [10.36.115.60]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 32CBF18649; Mon, 21 Jun 2021 07:06:04 +0000 (UTC) From: Florian Weimer To: "H.J. Lu via Libc-alpha" Subject: Re: [PATCH 1/4] Initial support for GNU_PROPERTY_1_NEEDED References: <20210620233620.391576-1-hjl.tools@gmail.com> <20210620233620.391576-2-hjl.tools@gmail.com> Date: Mon, 21 Jun 2021 09:06:03 +0200 In-Reply-To: <20210620233620.391576-2-hjl.tools@gmail.com> (H. J. Lu via Libc-alpha's message of "Sun, 20 Jun 2021 16:36:17 -0700") Message-ID: <87k0mnn1d0.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jun 2021 07:06:11 -0000 * H. J. Lu via Libc-alpha: > diff --git a/elf/elf.h b/elf/elf.h > index 2a62b98d4a..45b107fdcf 100644 > --- a/elf/elf.h > +++ b/elf/elf.h > @@ -1310,6 +1310,23 @@ typedef struct > /* No copy relocation on protected data symbol. */ > #define GNU_PROPERTY_NO_COPY_ON_PROTECTED 2 > > +/* A 4-byte unsigned integer property: A bit is set if it is set in all > + relocatable inputs. */ > +#define GNU_PROPERTY_UINT32_AND_LO 0xb0000000 > +#define GNU_PROPERTY_UINT32_AND_HI 0xb0007fff > + > +/* A 4-byte unsigned integer property: A bit is set if it is set in any > + relocatable inputs. */ > +#define GNU_PROPERTY_UINT32_OR_LO 0xb0008000 > +#define GNU_PROPERTY_UINT32_OR_HI 0xb000ffff > + > +/* The needed properties by the object file. */ > +#define GNU_PROPERTY_1_NEEDED GNU_PROPERTY_UINT32_OR_LO > + > +/* Set if the object file requires canonical function pointers and > + cannot be used with copy relocation. */ > +#define GNU_PROPERTY_1_NEEDED_SINGLE_GLOBAL_DEFINITION (1U << 0) > + > /* Processor-specific semantics, lo */ > #define GNU_PROPERTY_LOPROC 0xc0000000 > /* Processor-specific semantics, hi */ Please add a stable link to the full specification. I think we need more bits: one bit to indicate the status (in this patch), and another bit to indicate linker support for this feature. And perhaps yet another to indicate incompatibility with this feature. Thanks, Florian