From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 4B45B3857406 for ; Tue, 1 Jun 2021 12:40:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4B45B3857406 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-33-J5c5oHu_Pd2FUlCUInFR8g-1; Tue, 01 Jun 2021 08:40:20 -0400 X-MC-Unique: J5c5oHu_Pd2FUlCUInFR8g-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 86394189C448; Tue, 1 Jun 2021 12:40:19 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-113-228.ams2.redhat.com [10.36.113.228]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B1D175D9D0; Tue, 1 Jun 2021 12:40:18 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH v2 7/9] nptl: Implement raise in terms of pthread_kill References: <20210527172823.3461314-1-adhemerval.zanella@linaro.org> <20210527172823.3461314-8-adhemerval.zanella@linaro.org> Date: Tue, 01 Jun 2021 14:40:16 +0200 In-Reply-To: <20210527172823.3461314-8-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Thu, 27 May 2021 14:28:21 -0300") Message-ID: <87k0nd69n3.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jun 2021 12:40:23 -0000 * Adhemerval Zanella via Libc-alpha: > For Linux implementation, pthread_kill read the targeting TID from > the TCB. For raise, this it not possible because it would make raise > fail when issue after vfork (where creates the resulting process > has a different TID from the parent, but its TCB is not updated as > for pthread_create). To make raise use pthread_kill, it is make > usable from vfork by getting the target thread id through gettid > syscall. Please add the vfork information as a comment in pthread_kill. Otherwise looks good. Thanks, Florian