From: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
To: Raoni Fassina Firmino <raoni@linux.ibm.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] powerpc64le: Optimize memcpy for POWER10
Date: Fri, 30 Apr 2021 09:10:21 -0300 [thread overview]
Message-ID: <87k0okm0r6.fsf@linux.ibm.com> (raw)
In-Reply-To: <20210428181349.zetopsdjpt4asafn@work-tp>
Raoni Fassina Firmino via Libc-alpha <libc-alpha@sourceware.org> writes:
> On Tue, Apr 27, 2021 at 11:31:38PM -0300, AL glibc-alpha wrote:
> Not sure if subtract carrying (sub*c) that is used here and some places
> after is needed but don't hurt also.
The usages of subic. and subfic are indeed required, but I replaced subic with
subi.
> Should this label also be aligned with ".p2align 5" the same as the
> others?
It isn't mandatory.
> If memcpy-power10 is only for "le" should it be on the next section,
> inside this if:
>
> ifneq (,$(filter %le,$(config-machine)))
Fixed.
--
Tulio Magno
prev parent reply other threads:[~2021-04-30 12:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 2:31 Tulio Magno Quites Machado Filho
2021-04-28 13:31 ` Raphael M Zinsly
2021-04-28 14:22 ` Lucas A. M. Magalhaes
2021-04-28 18:13 ` Raoni Fassina Firmino
2021-04-30 0:24 ` [PATCHv2] " Tulio Magno Quites Machado Filho
2021-04-30 12:56 ` Raoni Fassina Firmino
2021-04-30 21:19 ` Tulio Magno Quites Machado Filho
2021-04-30 12:10 ` Tulio Magno Quites Machado Filho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0okm0r6.fsf@linux.ibm.com \
--to=tuliom@linux.ibm.com \
--cc=libc-alpha@sourceware.org \
--cc=raoni@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).