From: Florian Weimer <fweimer@redhat.com>
To: libc-alpha@sourceware.org
Cc: Stefan Liebler <stli@linux.ibm.com>
Subject: s390x: Diagnose missing VXE at run time if required at build time
Date: Tue, 06 Apr 2021 17:55:37 +0200 [thread overview]
Message-ID: <87k0pfmmpy.fsf@oldenburg.str.redhat.com> (raw)
It turns out that if glibc is built with -march=z14, it is still
possible to run up to dl_platform_init on z13 CPUs. This means we can
add a diagnostic to glibc, notifying the user that the CPU is too old.
The check is based on the way GCC sets the __LONG_DOUBLE_VX__
preprocessor macro:
s390_def_or_undef_macro (
pfile,
[] (const struct cl_target_option *opts) { return TARGET_VXE_P (opts); },
old_opts, opts, "__LONG_DOUBLE_VX__", "__LONG_DOUBLE_VX__");
diff --git a/sysdeps/s390/s390-64/dl-machine.h b/sysdeps/s390/s390-64/dl-machine.h
index 543361c83637c071..deaf37951206fb7c 100644
--- a/sysdeps/s390/s390-64/dl-machine.h
+++ b/sysdeps/s390/s390-64/dl-machine.h
@@ -235,6 +235,12 @@ _dl_start_user:\n\
static inline void __attribute__ ((unused))
dl_platform_init (void)
{
+#ifdef __LONG_DOUBLE_VX__
+ if (!(GLRO(dl_hwcap) & HWCAP_S390_VXE))
+ _dl_fatal_printf ("\
+Fatal glibc error: CPU lacks VXE support (z14 or later required)\n");
+#endif
+
if (GLRO(dl_platform) != NULL && *GLRO(dl_platform) == '\0')
/* Avoid an empty string which would disturb us. */
GLRO(dl_platform) = NULL;
next reply other threads:[~2021-04-06 15:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 15:55 Florian Weimer [this message]
2021-04-08 14:49 ` Stefan Liebler
2021-04-08 15:30 ` Florian Weimer
2021-04-09 8:35 ` Florian Weimer
2021-04-09 13:50 ` Stefan Liebler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0pfmmpy.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=stli@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).