From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fweimer@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by sourceware.org (Postfix) with ESMTP id E1E5B3858C27
 for <libc-alpha@sourceware.org>; Tue, 16 Mar 2021 05:10:16 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E1E5B3858C27
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-125-3OmTXmrSNQeUt-fH_bmTyw-1; Tue, 16 Mar 2021 01:10:14 -0400
X-MC-Unique: 3OmTXmrSNQeUt-fH_bmTyw-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com
 [10.5.11.14])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AAA241074659;
 Tue, 16 Mar 2021 05:10:12 +0000 (UTC)
Received: from oldenburg.str.redhat.com (ovpn-112-163.ams2.redhat.com
 [10.36.112.163])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 06B235D9D3;
 Tue, 16 Mar 2021 05:10:10 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: Lukasz Majewski <lukma@denx.de>
Cc: Adhemerval Zanella <adhemerval.zanella@linaro.org>,  Joseph Myers
 <joseph@codesourcery.com>,  GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] support: arm: Add libc_do_syscall function to
 libsupport routines
References: <20210315154723.11687-1-lukma@denx.de>
 <87eeggtnqx.fsf@oldenburg.str.redhat.com>
 <20210315231445.2e24b412@jawa>
Date: Tue, 16 Mar 2021 06:10:18 +0100
In-Reply-To: <20210315231445.2e24b412@jawa> (Lukasz Majewski's message of
 "Mon, 15 Mar 2021 23:14:45 +0100")
Message-ID: <87k0q7smyt.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW,
 RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Mar 2021 05:10:18 -0000

* Lukasz Majewski:

> Hi Florian,
>
>> * Lukasz Majewski:
>> 
>> > It fixes the following error on ARM 32 bit port:
>> >
>> > y2038-glibc/support/support_path_support_time64.c:34: undefined
>> > reference to `__libc_do_syscall'
>> > collect2: error: ld returned 1 exit status  
>> 
>> Should libsupport use syscall for direct system calls?
>
> I'm not sure what is the correct approach here.
>
> In my case - armv7, 32 bit - in support/support_path_support_time64.c
> the utimensat_time64 syscall is called, which is wrapped to
> INLINE_SYSCALL_CALL(), which calls __libc_do_syscall ASM ARM function.
>
> This function is only defined for i386 and 32 bit ARM (in e.g.
> sysdeps/unix/sysv/linux/{arm|i386}/libc-do-syscall.S)

Yes, and using the syscall function would avoid this issue.

So the question is, why INLINE_SYSCALL_CALL?

Thanks,
Florian