From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id 75C90384607A for ; Thu, 27 Aug 2020 11:10:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 75C90384607A Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-109-MTZ6bsETM5G73QXOWConVQ-1; Thu, 27 Aug 2020 07:10:27 -0400 X-MC-Unique: MTZ6bsETM5G73QXOWConVQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 56C30F6C04; Thu, 27 Aug 2020 11:10:26 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-112-37.ams2.redhat.com [10.36.112.37]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A9FFE757EC; Thu, 27 Aug 2020 11:10:25 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH 1/4] Sync getcwd with gnulib References: <20200826210246.2830973-1-adhemerval.zanella@linaro.org> <87ft881p5b.fsf@oldenburg2.str.redhat.com> <87o8mwz76v.fsf@oldenburg2.str.redhat.com> Date: Thu, 27 Aug 2020 13:10:24 +0200 In-Reply-To: (Adhemerval Zanella's message of "Thu, 27 Aug 2020 08:06:47 -0300") Message-ID: <87k0xkz6n3.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Aug 2020 11:10:30 -0000 * Adhemerval Zanella: > On Thu, Aug 27, 2020 at 7:58 AM Florian Weimer wrote: >> >> * Adhemerval Zanella: >> >> > This specific part is not used by glibc, for LIBC my patch sets >> > HAVE_MINIMALLY_WORKING_GETCWD >> > explicit to 0. I just added to sync with gnulib implementation and >> > make future changes less complex >> > (and it also checks if gnulib code to disable the LIBC part is working >> > correctly). >> >> I meant: Is anything of this used on Hurd at all? I don't think so. > > No, Hurd re implements getcwd.c. I personally would prefer to get > streamline version without all the clutter required to build on all > the platforms gnulib support, but my impression from other gnulib code > sync was that we should avoid it. Hmm. Maybe I will give this a try and see how much code is left after the cleanup. This shouldn't block the current sync if you want to go ahead with it. Thanks, Florian