From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id CE86D386180A for ; Wed, 8 Jul 2020 11:52:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CE86D386180A Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-191-pl7V-0btP-6UEdOyP5MelA-1; Wed, 08 Jul 2020 07:52:22 -0400 X-MC-Unique: pl7V-0btP-6UEdOyP5MelA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BA7171940920; Wed, 8 Jul 2020 11:52:21 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-112-117.ams2.redhat.com [10.36.112.117]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F02B45D9F3; Wed, 8 Jul 2020 11:52:17 +0000 (UTC) From: Florian Weimer To: Tamar Christina Cc: Adhemerval Zanella , Carlos O'Donell , "libc-alpha\@sourceware.org" Subject: Re: [PATCH v5 12/13] string: Add sigabbrev_np and sigdescr_np References: <20200619134352.297146-1-adhemerval.zanella@linaro.org> <20200619134352.297146-12-adhemerval.zanella@linaro.org> <05744028-6434-5c9f-7498-12965f0b793c@redhat.com> <87sge2tezr.fsf@oldenburg2.str.redhat.com> Date: Wed, 08 Jul 2020 13:52:16 +0200 In-Reply-To: (Tamar Christina's message of "Wed, 8 Jul 2020 11:48:06 +0000") Message-ID: <87k0zetea7.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jul 2020 11:52:27 -0000 * Tamar Christina: >> What's your GCC version? I don't see this when building with a GCC >> 10 cross- compiler. > > It seems to be GCC 6.3 from a native Debian docker image > > 0e188cdeda88 ~# gcc --version > ... > gcc version 6.3.0 20170516 (Debian 6.3.0-18+deb9u1) > ... > > 0e188cdeda88 ~# lsb_release -a > No LSB modules are available. > Distributor ID: Debian > Description: Debian GNU/Linux 9.12 (stretch) > Release: 9.12 > Codename: stretch I see. Looks like GCC 6 does not discard the const on the return type, although it has no effect in C: const char *const sigabbrev_np (int signum) { =E2=80=A6 Does this patch fixes things for you? diff --git a/string/sigabbrev_np.c b/string/sigabbrev_np.c index 3cbe14e769..a5ac6da053 100644 --- a/string/sigabbrev_np.c +++ b/string/sigabbrev_np.c @@ -20,7 +20,7 @@ #include #include =20 -const char *const +const char * sigabbrev_np (int signum) { const char *abbrev =3D NULL; diff --git a/string/sigdescr_np.c b/string/sigdescr_np.c index 5bcf814c1d..bf2d462b9c 100644 --- a/string/sigdescr_np.c +++ b/string/sigdescr_np.c @@ -20,7 +20,7 @@ #include #include =20 -const char *const +const char * __sigdescr_np (int signum) { const char *descr =3D NULL; Thanks, Florian