From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51925 invoked by alias); 13 Jun 2017 17:05:05 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 51810 invoked by uid 89); 13 Jun 2017 17:05:04 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,KHOP_DYNAMIC,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=adhere X-HELO: mx0a-001b2d01.pphosted.com From: "Tulio Magno Quites Machado Filho" To: Alan Modra Cc: libc-alpha@sourceware.org Cc: Subject: Re: [PATCH 3/6] PowerPC64 sysdep.h tidy In-Reply-To: <20170613012742.GC8406@bubble.grove.modra.org> References: <20170601130442.GF8842@bubble.grove.modra.org> <20170601130928.GI8842@bubble.grove.modra.org> <87tw3lcby1.fsf@linux.vnet.ibm.com> <20170613012742.GC8406@bubble.grove.modra.org> User-Agent: Notmuch/0.24.1 (http://notmuchmail.org) Emacs/25.2.1 (x86_64-redhat-linux-gnu) Date: Tue, 13 Jun 2017 17:05:00 -0000 MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-MML: disable x-cbid: 17061317-0024-0000-0000-0000017FBA7F X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17061317-0025-0000-0000-00001647D7FE Message-Id: <87k24fddj9.fsf@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-13_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706130295 X-SW-Source: 2017-06/txt/msg00561.txt.bz2 Alan Modra writes: > On Mon, Jun 12, 2017 at 03:12:22PM -0300, Tulio Magno Quites Machado Filho wrote: >> Alan Modra writes: >> >> > diff --git a/sysdeps/powerpc/powerpc64/sysdep.h b/sysdeps/powerpc/powerpc64/sysdep.h >> > index 4347323..860420e 100644 >> > --- a/sysdeps/powerpc/powerpc64/sysdep.h >> > +++ b/sysdeps/powerpc/powerpc64/sysdep.h >> > @@ -106,25 +106,25 @@ >> > # define OPD_ENT(name) .quad BODY_LABEL (name), .TOC.@tocbase, 0 >> > #endif >> > >> > -#define ENTRY_1(name) \ >> > +#define ENTRY_1(name) \ >> > .type BODY_LABEL(name),@function; \ >> > .globl name; \ >> > .section ".opd","aw"; \ >> > - .align 3; \ >> > -name##: OPD_ENT (name); \ >> > - .previous; >> > + .p2align 3;FUNC_LABEL(name): \ >> > + OPD_ENT (name); \ >> > + .previous >> >> I'm just curious: is this format written somewhere or used somewhere else? > > If you're referring to the label change, assembly labels generally > start in the first column (or immediately after a semicolon). On > targets that don't need a colon to mark a label that matters a lot, > since an identifier starting in the first column is a label and > anything past that is a directive or instruction.. PowerPC isn't such > a target, but it's a good convention to follow. I know it doesn't > look as nice the way the macro is written now. That's what I was referring to. > Hmm, perhaps I should change the relevant lines to: > > .p2align 3 \ > ;FUNC_LABEL(name): \ > OPD_ENT (name); \ I don't think that's necessary. I was just trying to clarify what was behind this change in order to adhere to the same convention next time. Thanks! -- Tulio Magno