public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: "Andrew Pinski (QUIC)" <quic_apinski@quicinc.com>
Cc: "libc-alpha@sourceware.org" <libc-alpha@sourceware.org>
Subject: Re: [PATCH v2 2/2] Aarch64: Add new memset for Qualcomm's 0ryon-1 core
Date: Tue, 14 May 2024 09:37:17 +0200	[thread overview]
Message-ID: <87le4cvo7m.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <SN6PR02MB4062BB8C827CB034D426997FB8E32@SN6PR02MB4062.namprd02.prod.outlook.com> (Andrew Pinski's message of "Tue, 14 May 2024 06:19:26 +0000")

* Andrew Pinski:

>> -----Original Message-----
>> From: Florian Weimer <fweimer@redhat.com>
>> Sent: Monday, May 13, 2024 6:49 AM
>> To: Andrew Pinski (QUIC) <quic_apinski@quicinc.com>
>> Cc: libc-alpha@sourceware.org
>> Subject: Re: [PATCH v2 2/2] Aarch64: Add new memset for Qualcomm's
>> 0ryon-1 core
>> 
>> * Andrew Pinski:
>> 
>> > Qualcom's new core, oryon-1, has a different characteristics for
>> > memset than the current versions of memset. For non-zero, larger
>> > sizes, using GPRs rather than the SIMD stores is ~30% faster.
>> > For even larger sizes, using the nontemporal stores is needed not to
>> > polute the L1/L2 caches.
>> 
>> NB: Commit subject has 0ryon with a zero instead of an O.  Not sure
>> if this is intentional.
>
> No, it was a typo, the `o` is right below the 0 on the keyboard and I
> did not notice that typo until you mentioned it.  Should I submit a
> new patch with the typo fixed in the subject line or will the person
> committing it will fix it?

If found some other nits, so maybe repost it?  We can then consider
applying it.

I suppose you will be around to maintain these implementations?

Thanks,
Florian


  reply	other threads:[~2024-05-14  7:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-08 16:59 [PATCH v2 1/2] Aarch64: Add memcpy for qualcomm's oryon-1 core Andrew Pinski
2024-05-08 16:59 ` [PATCH v2 2/2] Aarch64: Add new memset for Qualcomm's 0ryon-1 core Andrew Pinski
2024-05-13 13:48   ` Florian Weimer
2024-05-14  6:19     ` Andrew Pinski (QUIC)
2024-05-14  7:37       ` Florian Weimer [this message]
2024-05-14  7:47         ` Andrew Pinski (QUIC)
2024-05-14  9:10           ` Florian Weimer
2024-05-14  7:32   ` Florian Weimer
2024-05-14  7:40     ` Andrew Pinski (QUIC)
2024-05-22 23:01       ` Andrew Pinski (QUIC)
2024-05-23 13:08         ` Adhemerval Zanella Netto
2024-05-14  7:35 ` [PATCH v2 1/2] Aarch64: Add memcpy for qualcomm's oryon-1 core Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87le4cvo7m.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=quic_apinski@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).