From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 5C2CE3858D1E for ; Tue, 14 May 2024 07:37:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5C2CE3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5C2CE3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715672248; cv=none; b=rEnVVDUrTAsH86FzmdSR8B2owMOzl/HmLLilfFCr8zsIiGtS6CB7Yi5t6K9V9+RorUu16riYuUoUwezjY6SKDFqAtPwRvEgdkK9mYxAn2La8hcrbVGR0F3olz3WDKFazX3ayEj0zU6pGgE18dJRjJI0ZvJdN89pyNOkPxXsS0qU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715672248; c=relaxed/simple; bh=4UBc3DI+rVVSOJplqWqYZgszbgd06Etah9igP2sDUJA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=gSiEGVzCZiNB8we16TMfsYPq8xX/2r+27LcnroEV55RZ20k4e5J9wI1gN1bKGIOD0wTbv1Ccz6LHThHEu6rDTaUP6ucbq2dncAonhxMEEzP+dWBgwYG/5ILgev+4o/Sx9vXUvP+rgIrKlmaf4xEFpKZ8eNpdBnK2GfVYfnfzBxw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715672247; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jCv+0FqvMUS12GroaF2E190qVokIRskMGD0HQ3649Ek=; b=ElrCFUqeA0QeWW15Md6AJ2eCwcfMLbWx99Q1ItQtZt3p8RJYXqaJHav8Asvn808jxN8Ddb 8WFwLT7kwIpalDqvph9pmMScBE/WgN71QZiPik40+idUbPzEP6IBnMUn0Z1xWPcL3FhPEI rjX/9hEBYEUekz7Qh8Nf9rxl18cMtJw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-672-7VZuchS0PLiqVFPA9zmBFg-1; Tue, 14 May 2024 03:37:20 -0400 X-MC-Unique: 7VZuchS0PLiqVFPA9zmBFg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2BE73101A54F; Tue, 14 May 2024 07:37:20 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 52D6041D; Tue, 14 May 2024 07:37:19 +0000 (UTC) From: Florian Weimer To: "Andrew Pinski (QUIC)" Cc: "libc-alpha@sourceware.org" Subject: Re: [PATCH v2 2/2] Aarch64: Add new memset for Qualcomm's 0ryon-1 core In-Reply-To: (Andrew Pinski's message of "Tue, 14 May 2024 06:19:26 +0000") References: <20240508165924.874710-1-quic_apinski@quicinc.com> <20240508165924.874710-2-quic_apinski@quicinc.com> <87ikzhn7pg.fsf@oldenburg.str.redhat.com> Date: Tue, 14 May 2024 09:37:17 +0200 Message-ID: <87le4cvo7m.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Andrew Pinski: >> -----Original Message----- >> From: Florian Weimer >> Sent: Monday, May 13, 2024 6:49 AM >> To: Andrew Pinski (QUIC) >> Cc: libc-alpha@sourceware.org >> Subject: Re: [PATCH v2 2/2] Aarch64: Add new memset for Qualcomm's >> 0ryon-1 core >> >> * Andrew Pinski: >> >> > Qualcom's new core, oryon-1, has a different characteristics for >> > memset than the current versions of memset. For non-zero, larger >> > sizes, using GPRs rather than the SIMD stores is ~30% faster. >> > For even larger sizes, using the nontemporal stores is needed not to >> > polute the L1/L2 caches. >> >> NB: Commit subject has 0ryon with a zero instead of an O. Not sure >> if this is intentional. > > No, it was a typo, the `o` is right below the 0 on the keyboard and I > did not notice that typo until you mentioned it. Should I submit a > new patch with the typo fixed in the subject line or will the person > committing it will fix it? If found some other nits, so maybe repost it? We can then consider applying it. I suppose you will be around to maintain these implementations? Thanks, Florian