From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 0AC6A3849AFF for ; Sat, 13 Apr 2024 17:51:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0AC6A3849AFF Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0AC6A3849AFF Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713030671; cv=none; b=phMNGm+jMbZChk+9N1OVvsBUkl3y2AE5DBolWQ3rZKiajCiYL7NY9/FGwHHP7vaLp9wTCSrQO2PVjd3AUqlwXJY8zm5Kvai4bObeonzeJikKFIi71M3BLLlmR9hwJR85F+vOa9G1TsQAOUlnrCZE0K5/93Jw++NpPnwQcDvOf7Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713030671; c=relaxed/simple; bh=VPWhQYlk59I7W90QDXGYpgUVBQdJpVgI7VZYGMsFuS8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=WlMjqU9dGicrmubNk1+0BsVzDOq2OXcNm5prIbgAsC82IbDm1MIH5vGaNRB4RUHtSY626Bv5dxOG91/trPWRLavwnWaYWKyAJGrNJdzAcjcYPL2UfWZUkHeM513b6u7aP5/7nl0M//qw7v9h+oZYtyXFXOR3I9aKUsNHBAshAnw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713030667; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xog3TrhjcCNUvtOB8TQwy88k4kJznoZsQlBusXLpV5g=; b=FBrcs4njtjz6vi3tsxF8y7pYd73vv1psngZ5jHG2A2poE3t56OTZbg9EHN2JAxtWtldVYV EwZANgm/o1igHr30YVByTCHmEPKEyW1j45yWy5rk3IWWgjqFmARHB7qlaAs0AVIFpG0OPU cewn20niDwqPBU51H7wRc0iNL3DWwpc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-58-MqIA5z1wOmq2oaUhm7LT8A-1; Sat, 13 Apr 2024 13:51:04 -0400 X-MC-Unique: MqIA5z1wOmq2oaUhm7LT8A-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 00DC91887315; Sat, 13 Apr 2024 17:51:04 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.193.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EA8A5492BCA; Sat, 13 Apr 2024 17:51:02 +0000 (UTC) From: Florian Weimer To: "H.J. Lu" Cc: libc-alpha@sourceware.org, Sunil K Pandey Subject: Re: [PATCH] Revert "x86_64: Suppress false positive valgrind error" In-Reply-To: (H. J. Lu's message of "Sat, 13 Apr 2024 08:56:36 -0700") References: <87a5lx2u9a.fsf@oldenburg.str.redhat.com> <875xwl2tku.fsf@oldenburg.str.redhat.com> <871q792ssr.fsf@oldenburg.str.redhat.com> <87plut1cqd.fsf@oldenburg.str.redhat.com> Date: Sat, 13 Apr 2024 19:50:57 +0200 Message-ID: <87le5h179a.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * H. J. Lu: >> >> > Could someone proficient in x86-64 assembly have a look at my strcm= p >> >> > implementation? >> >> >> >> Can you adapt sysdeps/i386/i686/strcmp.S for valgrind? >> >> >> > >> > You can use sysdeps/x86_64/strcmp.S from glibc 2.10: >> >> True. It's mostly a licensing matter at this point. The copyright >> notice is longer than the assemly =E2=80=A6 > > You can hook your strcmp into glibc and run the glibc strcmp test. > If it passes the test, it is good to go. Good suggestion. I verified that it runs, and there are no errors. So I think we have a solution. Thanks, Florian