From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 662EE3858C24 for ; Fri, 5 Apr 2024 14:54:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 662EE3858C24 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 662EE3858C24 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712328865; cv=none; b=ZDG8V6fVcC6a0AK+v9FvRcHaxb0b0q49OO+tQmDn+W1ylKBdYC7YpUxTZLr2zWfBU42nOt4qgDgQE+O4pOIVticDFPC84qS249OJFrDB9u6GI9JL0Jd51H2QVQJqZqd7cTCOndgkjkrvjzlExVcEJ0I5H3TJ3T90hU7dgxRNxNc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712328865; c=relaxed/simple; bh=Kbf/Of4AfCz65sS0kDxBIvVUwzGcnm8+R+jf0ouolHw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=pFNHOKkZFxsmkqB6AQVHDQz+Ip4Lw4u9yAlu4xt5nbhb+FJJcdlr2PiU0kIEJTAbV1rA7CMXe5EOUav3LDBtej2teLuBmE8x7+tTR4rSHC3l1fffa5eSHl2aMbWCzxOn478QXMsi4ZvGtaJJE+nfmh90hQKKod56p1wS9+njycY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712328862; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gi6A/wGAwCHJzr6Kfe3EDKI4X8HLyTG4jwvXqDrxed8=; b=hNMW6bEmbVNO+FhnOQBKZ+nMANnJ3V4vvMRiWyYs8h9IOeor1Y22XF86oVxVTCJvWvOti9 6NQOmrsVs8Ci5GRZSkLh36PoFLUVC322FllHewXvITQCFD0iZA5HRk/zFv53GZzi56GXC+ qxaXrgQMnPPtKJfEXCdSxz5HOzhJpps= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-475-ubJplriAPn2630P-O6TFAw-1; Fri, 05 Apr 2024 10:54:18 -0400 X-MC-Unique: ubJplriAPn2630P-O6TFAw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 902A51C2CECC; Fri, 5 Apr 2024 14:54:18 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0BA5F1121337; Fri, 5 Apr 2024 14:54:17 +0000 (UTC) From: Florian Weimer To: Szabolcs Nagy Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v3 3/3] aarch64: Enhanced CPU diagnostics for ld.so In-Reply-To: (Szabolcs Nagy's message of "Fri, 5 Apr 2024 15:49:51 +0100") References: Date: Fri, 05 Apr 2024 16:54:12 +0200 Message-ID: <87le5r273f.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Szabolcs Nagy: > The 04/05/2024 12:16, Florian Weimer wrote: >> This prints some information from struct cpu_features, and the midr_el1 >> and dczid_el0 system register contents on every CPU. > > thanks. > > i think we already rely on zva size to be the same across all cores > (in memset) and i don't think linux allows different dczid_el0 per > core (even if somebody built such a system). > > so i don't think that is needed. Well =E2=80=A6 we've seen per-core feature sets change on some cores after suspend/resume (although not on aarch64). That's why we have t he per-CPU iterator in the first place. > i wonder if we should place a comment in init-arch.h to update > _dl_diagnostics_cpu in case ifunc rules change as this seems > easy to forget I'll add a comment. Thanks, Florian