From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 9AE233858C78 for ; Wed, 6 Sep 2023 20:48:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9AE233858C78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694033302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QgVqWz78sdUcgQKTakgZgH7h3Jrt5ALY1V7tA9iYvhY=; b=gUmTEZMYD4iPCqF58VWuxl54jgx3FoITYDZzz24a8H06FJWRQyhFB0EnDlT5lhNJupkh9w WcX9/DF1YA+oNsrpCi2eIOU8IPYy9HzC429FnIO9RCRV9jftSazdkhCkDtv9PbrIMBk0xb d2OgovUear/ZJNMMXuqoPm7L84qX6H4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-516-24iPYNBdPL2rgMp1ponSlQ-1; Wed, 06 Sep 2023 16:48:19 -0400 X-MC-Unique: 24iPYNBdPL2rgMp1ponSlQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A20B81008139; Wed, 6 Sep 2023 20:48:18 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E347C404119; Wed, 6 Sep 2023 20:48:17 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella via Libc-alpha Cc: Mateusz Guzik , Linus Torvalds , Adhemerval Zanella Subject: Re: [PATCH] io: Do not implement fstat with fstatat References: <20230905203421.2127750-1-adhemerval.zanella@linaro.org> Date: Wed, 06 Sep 2023 22:48:16 +0200 In-Reply-To: <20230905203421.2127750-1-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Tue, 5 Sep 2023 17:34:21 -0300") Message-ID: <87ledjxc33.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Adhemerval Zanella via Libc-alpha: > diff --git a/sysdeps/unix/sysv/linux/fstat64.c b/sysdeps/unix/sysv/linux/fstat64.c > index 124384e57f..a7f4935a01 100644 > --- a/sysdeps/unix/sysv/linux/fstat64.c > +++ b/sysdeps/unix/sysv/linux/fstat64.c > int > __fstat64_time64 (int fd, struct __stat64_t64 *buf) > { > +#if !FSTATAT_USE_STATX > +# if XSTAT_IS_XSTAT64 > +# ifdef __NR_newfstatat > + /* 64-bit kABI, e.g. aarch64, ia64, powerpc64*, s390x, riscv64, and > + x86_64. */ > + return INLINE_SYSCALL_CALL (fstat, fd, buf); It's a bit suspicious to check for __NR_newfstatat an then use fstat. Could you add a comment to explain this? Surprisingly it compiles on all architectures. Thanks, Florian