From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 525A13858D28 for ; Tue, 29 Aug 2023 08:03:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 525A13858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1693296194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kz+AsjY2ThjHb2t9nZmW+eiL6YzH5CaGlpDZ+YY+dac=; b=UOTx7LR+W4iLJc7FCYIuv42UKYQNUuRbvLXEFLpMBk+9wJkdrePkfewruSsTmb7zQyKTGf C3QdwN8a62KKjxWxqCvBpNRtwTt9G3QrxVGWy+ymMX9G3/PblruyEgNICfd0czk6jrDdTz O+CilS6RB0+fLrEW3jchvpzFtH/CVNM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-528-NB0VBXipPMW3pjh1T8L82A-1; Tue, 29 Aug 2023 04:03:10 -0400 X-MC-Unique: NB0VBXipPMW3pjh1T8L82A-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C898C183B3C0 for ; Tue, 29 Aug 2023 08:03:09 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3CD85140E950; Tue, 29 Aug 2023 08:03:09 +0000 (UTC) From: Florian Weimer To: Joe Simmons-Talbott via Libc-alpha Cc: Joe Simmons-Talbott Subject: Re: [PATCH v2] getpw: Get rid of alloca References: <20230828194911.877648-1-josimmon@redhat.com> Date: Tue, 29 Aug 2023 10:03:07 +0200 In-Reply-To: <20230828194911.877648-1-josimmon@redhat.com> (Joe Simmons-Talbott via Libc-alpha's message of "Mon, 28 Aug 2023 15:48:59 -0400") Message-ID: <87ledunumc.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Joe Simmons-Talbott via Libc-alpha: > Since _SC_GETPW_R_SIZE_MAX will be always NSS_BUFLEN_PASSWD, use a fixed > sized array rather than alloca to avoid potential stack overflow. _SC_GETPW_R_SIZE_MAX is not very well-named, it is the initial suggested buffer size. The code should use the usual scratch buffer retry loop. Thanks, Florian