From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 160003858C52 for ; Sun, 9 Jul 2023 06:18:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 160003858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org References: <78b648da-dde7-d331-7384-03214b977e6d@kernel.org> <20230709061011.1885809-1-eggert@cs.ucla.edu> User-agent: mu4e 1.10.4; emacs 29.0.92 From: Sam James To: libc-coord@lists.openwall.com Cc: Alejandro Colomar , "A . Wilcox" , Jonathan Wakely , Rich Felker , linux-man@vger.kernel.org, libc-alpha@sourceware.org, musl@lists.openwall.com, Sam James , Szabolcs Nagy , Jakub Wilk , Paul Eggert Subject: Re: [libc-coord] [PATCH v4] off64_t: prefer off_t for splice, etc. Date: Sun, 09 Jul 2023 07:16:17 +0100 In-reply-to: <20230709061011.1885809-1-eggert@cs.ucla.edu> Message-ID: <87lefpehgo.fsf@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Paul Eggert writes: > For the few functions that come only in 64-bit off_t flavors, > document their APIs as using off_t instead of off64_t, > and say also that code should #define _FILE_OFFSET_BITS 64. > This documents what user code is (and should be) doing anyway, > if it needs to work on traditional x86 and ARM Linux. LGTM and thank you Paul. I haven't checked for other prototypes/examples which need changing.