From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id AF9CD3858D33 for ; Mon, 15 May 2023 19:26:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AF9CD3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684178770; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+IlPaYgVNtv8pacmSjesLA1qG7Au7RoBQDA6B0aeORY=; b=Q6zxBccjEabKI0smhI3SS7PaxR2pbpu7RoHYVcbfys3gNK7GyXySnkdWpW54g1SCSrJTtU 6/x/StZFrnuHyAixqvwpgCqs84l+8gqm0ognYIzcdbYzxbO0dRUrulVyarsbR3x3KbSdds cXfyhWfLvI6vFMUTeWSkxgFdQc3TEho= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-9-33WP9JDeNT6Itv8hgbNk8Q-1; Mon, 15 May 2023 15:26:06 -0400 X-MC-Unique: 33WP9JDeNT6Itv8hgbNk8Q-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9C6A0857E13; Mon, 15 May 2023 19:26:05 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.178]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A25812026D16; Mon, 15 May 2023 19:26:04 +0000 (UTC) From: Florian Weimer To: MAHESH BODAPATI Cc: MAHESH BODAPATI via Libc-alpha , rajis@linux.ibm.com, Mahesh Bodapati Subject: Re: [PATCH] powerpc:GCC(<10) doesn't allow -mlong-double-64 after -mabi=ieeelongdouble References: <20230512102259.2329923-1-bmahi496@linux.ibm.com> <87353x91wj.fsf@oldenburg.str.redhat.com> Date: Mon, 15 May 2023 21:26:03 +0200 In-Reply-To: (MAHESH BODAPATI's message of "Mon, 15 May 2023 23:33:13 +0530") Message-ID: <87lehp75x0.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * MAHESH BODAPATI: > On 15/05/23 6:39 pm, Florian Weimer wrote: >> * MAHESH BODAPATI via Libc-alpha: >> >>> From: Mahesh Bodapati >>> >>> Removed -mabi=3Dieeelongdouble on failing tests. It resolves the error. >>> error: =E2=80=98-mabi=3Dieeelongdouble=E2=80=99 requires =E2=80=98-mlon= g-double-128=E2=80=99 >> I think this is only need if GCC defaults to -mabi=3Dieeelongdouble, and >> GCC 10 is not ready for that for different reasons? > > Yes,these tests are under "sysdeps/ieee754/ldbl-opt" and ieee754 > defaults to -mabi=3Dieeelongdouble and the > > CFLAGS were appended with -mlong-double-64 in commit > dee2bea048b688b643a9a ,but powerpc gcc (<10) > > doesn't support mabi=3Dieeelongdouble with -mlong-double-64.the support > has been addedin gcc 12.1 and > > it has been back-ported till gcc 10 so we are filtering out the > -mabi=3Dieelongdouble to make it work I think if you backport this stuff to GCC 10, you should also pick up the commit that fixed GCC. I believe its commit cb16bc3b5f34733ef9bb ("rs6000: Allow -mlong-double-64 after -mabi=3D{ibm,ieee}longdouble [PR104208, P R87496]"). Thanks, Florian