From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by sourceware.org (Postfix) with ESMTPS id A05DE3858C55 for ; Thu, 29 Sep 2022 20:01:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A05DE3858C55 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nefkom.net Received: from frontend03.mail.m-online.net (unknown [192.168.6.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4Mdkl22SXjz1r154; Thu, 29 Sep 2022 22:01:17 +0200 (CEST) Received: from localhost (dynscan3.mnet-online.de [192.168.6.84]) by mail.m-online.net (Postfix) with ESMTP id 4Mdkl145Ylz1qqlR; Thu, 29 Sep 2022 22:01:17 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan3.mail.m-online.net [192.168.6.84]) (amavisd-new, port 10024) with ESMTP id aVpFjRhE_Mx0; Thu, 29 Sep 2022 22:01:16 +0200 (CEST) X-Auth-Info: KrcS6SCVIgUlz21iCD+O3s4f3SlvxfQ7f6AcIdO66LTyREZOmZ4OxMW/HTxsb9tm Received: from igel.home (dynamic-046-114-002-140.46.114.pool.telefonica.de [46.114.2.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Thu, 29 Sep 2022 22:01:16 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id D7D182C25FF; Thu, 29 Sep 2022 22:01:15 +0200 (CEST) From: Andreas Schwab To: "H.J. Lu via Libc-alpha" Cc: Adhemerval Zanella , "H.J. Lu" , Yu Chien Peter Lin , Wilco Dijkstra Subject: Re: [PATCH 1/2] stdlib: Fix __getrandom_nocancel type and arc4random usage (BZ #29638) References: <20220929192756.3310704-1-adhemerval.zanella@linaro.org> X-Yow: While my BRAINPAN is being refused service in BURGER KING, Jesuit priests are DATING CAREER DIPLOMATS!! Date: Thu, 29 Sep 2022 22:01:15 +0200 In-Reply-To: (H. J. Lu via Libc-alpha's message of "Thu, 29 Sep 2022 12:39:27 -0700") Message-ID: <87leq2osqc.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sep 29 2022, H.J. Lu via Libc-alpha wrote: >> diff --git a/sysdeps/unix/sysv/linux/not-cancel.h b/sysdeps/unix/sysv/linux/not-cancel.h >> index a263d294b1..cf35c8bfc9 100644 >> --- a/sysdeps/unix/sysv/linux/not-cancel.h >> +++ b/sysdeps/unix/sysv/linux/not-cancel.h >> @@ -68,7 +68,7 @@ __writev_nocancel_nostatus (int fd, const struct iovec *iov, int iovcnt) >> INTERNAL_SYSCALL_CALL (writev, fd, iov, iovcnt); >> } >> >> -static inline int >> +static inline ssize_t > > Shouldn't it be __syscall_slong_t? getrandom can never return more than the size of the buffer. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."