public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
Cc: libc-alpha@sourceware.org,  murphyp@linux.ibm.com
Subject: Re: [PATCHv2] Apply asm redirections in stdio.h before first use [BZ #27087]
Date: Mon, 04 Jul 2022 09:07:48 +0200	[thread overview]
Message-ID: <87let973uj.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20220630220543.112982-1-tuliom@linux.ibm.com> (Tulio Magno Quites Machado Filho's message of "Thu, 30 Jun 2022 19:05:43 -0300")

* Tulio Magno Quites Machado Filho:

> diff --git a/libio/bits/stdio2-dec.h b/libio/bits/stdio2-dec.h
> new file mode 100644
> index 0000000000..80ab10bccf
> --- /dev/null
> +++ b/libio/bits/stdio2-dec.h
> @@ -0,0 +1,110 @@
> +/* Checking macros for stdio functions. Declarations only.
> +   Copyright (C) 2004-2021 Free Software Foundation, Inc.

Copyright range should end in 2022.

> +extern int __sprintf_chk (char *__restrict __s, int __flag, size_t __slen,
> +			  const char *__restrict __format, ...) __THROW
> +    __attr_access ((__write_only__, 1, 3));
> +extern int __vsprintf_chk (char *__restrict __s, int __flag, size_t __slen,
> +			   const char *__restrict __format,
> +			   __gnuc_va_list __ap) __THROW
> +    __attr_access ((__write_only__, 1, 3));
> +
> +#if defined __USE_ISOC99 || defined __USE_UNIX98
> +
> +extern int __snprintf_chk (char *__restrict __s, size_t __n, int __flag,
> +			   size_t __slen, const char *__restrict __format,
> +			   ...) __THROW
> +    __attr_access ((__write_only__, 1, 2));
> +extern int __vsnprintf_chk (char *__restrict __s, size_t __n, int __flag,
> +			    size_t __slen, const char *__restrict __format,
> +			    __gnuc_va_list __ap) __THROW;

__attr_access is missing for __vsnprintf_chk?  Hmm, I see that it was
missing before as well.

Thanks,
Florian


  reply	other threads:[~2022-07-04  7:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-15 19:23 [PATCH] " Tulio Magno Quites Machado Filho
2021-12-17 17:44 ` Paul E Murphy
2022-06-30 22:05   ` [PATCHv2] " Tulio Magno Quites Machado Filho
2022-07-04  7:07     ` Florian Weimer [this message]
2022-07-07 12:52     ` Andreas Schwab
2022-07-07 21:12       ` [PATCHv3] " Tulio Magno Quites Machado Filho
2022-07-11 20:33         ` Paul E Murphy
2022-07-12 13:36           ` Carlos O'Donell
2022-07-14 19:40             ` Tulio Magno Quites Machado Filho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87let973uj.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=murphyp@linux.ibm.com \
    --cc=tuliom@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).