From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id A96E2385781A for ; Thu, 21 Apr 2022 10:00:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A96E2385781A Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-627-9pJ8K8SbMB-V8OqQgtjN3g-1; Thu, 21 Apr 2022 06:00:11 -0400 X-MC-Unique: 9pJ8K8SbMB-V8OqQgtjN3g-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0CF2686B8A3 for ; Thu, 21 Apr 2022 10:00:11 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.193.187]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 63E15145BEE1 for ; Thu, 21 Apr 2022 10:00:10 +0000 (UTC) From: Florian Weimer To: libc-alpha@sourceware.org Subject: Re: [PATCH] libio: Remove _IO_adjust_column, _IO_adjust_wcolumn, column tracking References: <87pmlavjwv.fsf@oldenburg.str.redhat.com> Date: Thu, 21 Apr 2022 12:00:08 +0200 In-Reply-To: <87pmlavjwv.fsf@oldenburg.str.redhat.com> (Florian Weimer's message of "Thu, 21 Apr 2022 11:57:04 +0200") Message-ID: <87levyvjrr.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Apr 2022 10:00:14 -0000 * Florian Weimer: > Column number tracking was removed from the iostream library during > C++98 standardization. It looks like it was never used by > applications. > > On most ports, this is hard symbol removal (no compatibility symbol). > However, for GLIBC_2.0 ports, it is necessary to keep an > _IO_adjust_column export because old libstdc++ references this symbol, > although after the column number is no longer updated by glibc, > it will not be called anymore. > > _IO_adjust_wcolumn was never used in libstdc++. (The wide character > support was not completed before the switch to C++98 and > its template-based implementation.) > > Tested on i686-linux-gnu and x86_64-linux-gnu. Built with > build-many-glibcs.py. And I forgot the NEWS entry: diff --git a/NEWS b/NEWS index 4b6d9de2b5..e04aa771f5 100644 --- a/NEWS +++ b/NEWS @@ -17,6 +17,12 @@ Deprecated and removed features, and other changes affecting compatibility: removal of the LD_TRACE_PRELINKING, and LD_USE_LOAD_BIAS, environment variables and their functionality in the dynamic loader. +* Column number tracking for streams and the _IO_adjust_column and + _IO_adjust_wcolumn functions have been removed. For targets with the + GLIBC_2.0 symbol version, a compatibility definition of + _IO_adjust_column is still provided; otherwise the symbols have been + removed completely. + Changes to build and runtime requirements: [Add changes to build and runtime requirements here] Thanks, Florian