From: Florian Weimer <fweimer@redhat.com>
To: Szabolcs Nagy via Libc-alpha <libc-alpha@sourceware.org>
Cc: Szabolcs Nagy <szabolcs.nagy@arm.com>
Subject: Re: [PATCH v2 2/2] aarch64: Move ld.so _start to separate file
Date: Wed, 13 Apr 2022 13:49:52 +0200 [thread overview]
Message-ID: <87lew942zj.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <eab9f2a4ff63d066d7419610d6522c9ce095f128.1649848608.git.szabolcs.nagy@arm.com> (Szabolcs Nagy via Libc-alpha's message of "Wed, 13 Apr 2022 12:20:29 +0100")
* Szabolcs Nagy via Libc-alpha:
> A separate asm file is easier to maintain than a macro that expands to
> inline asm.
>
> The RTLD_START macro is only needed now because _dl_start is local in
> rtld.c, but _start has to call it, if _dl_start was made hidden then it
> could be empty.
The commit message should mention _dl_skip_args because it's not just a
verbatime move.
Thanks,
Florian
prev parent reply other threads:[~2022-04-13 11:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 11:20 [PATCH v2 0/2] Args adjustment with ./ld.so exe [BZ #23293] Szabolcs Nagy
2022-04-13 11:20 ` [PATCH v2 1/2] aarch64: Use generic argv adjustment in ld.so " Szabolcs Nagy
2022-04-13 11:20 ` [PATCH v2 2/2] aarch64: Move ld.so _start to separate file Szabolcs Nagy
2022-04-13 11:49 ` Florian Weimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lew942zj.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).