From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 49B60386001F for ; Mon, 31 Jan 2022 16:37:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 49B60386001F Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-98-OtxPjJXANqS59a1kGa-tHA-1; Mon, 31 Jan 2022 11:37:24 -0500 X-MC-Unique: OtxPjJXANqS59a1kGa-tHA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D7CE192500; Mon, 31 Jan 2022 16:37:23 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.193.205]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 11D09348E0; Mon, 31 Jan 2022 16:37:22 +0000 (UTC) From: Florian Weimer To: Andreas Schwab Cc: Florian Weimer via Libc-alpha Subject: Re: [PATCH 1/2] localedef: Fix handling of empty mon_decimal_point References: <20220131053442.3995804-1-carlos@redhat.com> <20220131053442.3995804-2-carlos@redhat.com> <87bkzs7wp1.fsf@oldenburg.str.redhat.com> <87ee4n6g56.fsf@igel.home> <87v8xz7u6u.fsf@oldenburg.str.redhat.com> <87a6fb6f6k.fsf@igel.home> Date: Mon, 31 Jan 2022 17:37:20 +0100 In-Reply-To: <87a6fb6f6k.fsf@igel.home> (Andreas Schwab's message of "Mon, 31 Jan 2022 17:30:27 +0100") Message-ID: <87leyv7tfj.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jan 2022 16:37:29 -0000 * Andreas Schwab: > On Jan 31 2022, Florian Weimer wrote: > >> * Andreas Schwab: >> >>> On Jan 31 2022, Florian Weimer via Libc-alpha wrote: >>> >>>> There's an existing comment >>>> >>>> /* The decimal point must not be empty. This is not said explicitly >>>> in POSIX but ANSI C (ISO/IEC 9899) says in 4.4.2.1 it has to be >>>> != "". */ >>>> >>>> that says that empty strings/null characters are invalid. >>> >>> This is only about decimal_point, mon_decimal_point can be empty. >> >> Hmm, I'll take your word for it. > > See 7.11.2.1, paragraph 3 and 10. That is fairly conclusive indeed (numbers match C11). Are you okay with Carlos' patch with a comment update? Thanks, Florian