From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id DFE94385842A for ; Fri, 28 Jan 2022 14:02:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DFE94385842A Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-347-XIczIPEBOBKTeebM_RdYhQ-1; Fri, 28 Jan 2022 09:02:26 -0500 X-MC-Unique: XIczIPEBOBKTeebM_RdYhQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A638B100CC84; Fri, 28 Jan 2022 14:02:25 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.8]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 86F5D708D2; Fri, 28 Jan 2022 14:02:14 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, Carlos O'Donell Subject: Re: [PATCH v5 3/3] Linux: Only generate 64 bit timestamps for 64 bit time_t recvmsg/recvmmsg References: <20220127201542.2306657-1-adhemerval.zanella@linaro.org> <20220127201542.2306657-4-adhemerval.zanella@linaro.org> Date: Fri, 28 Jan 2022 15:02:12 +0100 In-Reply-To: <20220127201542.2306657-4-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Thu, 27 Jan 2022 17:15:42 -0300") Message-ID: <87lez0j6vv.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Jan 2022 14:02:32 -0000 * Adhemerval Zanella: > diff --git a/sysdeps/unix/sysv/linux/tst-socket-timestamp-compat.c b/sysdeps/unix/sysv/linux/tst-socket-timestamp-compat.c > +/* Check if recvmsg create the additional 64 bit timestamp if only 32 bit > + is enabled for 64 bit recvmsg symbol. */ > +static void > +do_test_large_buffer (bool mc) > +{ > + struct mmsghdr mmhdr = { 0 }; > + /* It should be large enought for either timeval/timespec and the > + 64 time type as well. */ > + char msgbuf[512]; I think this needs a union with struct cmsgbuf to ensure alignment. Alternatively, use malloc. > +static void > +do_test_small_buffer (bool mc) > +{ > + struct mmsghdr mmhdr = { 0 }; > + > + /* Enable 32 bit timeval precision and check if no 64 bit timeval stamp > + is created. */ > + { > + char msgbuf[CMSG_SPACE (sizeof (struct timeval))]; Likewise. Rest looks okay. The kernel does not pass on whether a time32 or time64 system call was used, so implementing time32 recvmsg with recvmsg_time64 is fine in that regard. Thanks, Florian