From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id E0F463858C39 for ; Fri, 14 Jan 2022 14:27:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E0F463858C39 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-217-PUvUn-I-OU2moy6FL7KSMQ-1; Fri, 14 Jan 2022 09:27:42 -0500 X-MC-Unique: PUvUn-I-OU2moy6FL7KSMQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 624D11006AA3; Fri, 14 Jan 2022 14:27:41 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.49]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 84F387E2C7; Fri, 14 Jan 2022 14:27:40 +0000 (UTC) From: Florian Weimer To: "H.J. Lu" Cc: GNU C Library Subject: Re: [PATCH 3/7] elf: Split dl-printf.c from dl-misc.c References: <905c03a4ee231961ca1dd4fc74e49ebf97299b0d.1642162312.git.fweimer@redhat.com> Date: Fri, 14 Jan 2022 15:27:38 +0100 In-Reply-To: (H. J. Lu's message of "Fri, 14 Jan 2022 06:25:39 -0800") Message-ID: <87lezitmsl.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jan 2022 14:27:47 -0000 * H. J. Lu: > On Fri, Jan 14, 2022 at 4:42 AM Florian Weimer via Libc-alpha > wrote: >> >> This allows to use different compiler flags for the diagnostics >> code. >> --- >> elf/Makefile | 2 +- >> elf/dl-misc.c | 281 +--------------------------------------------- >> elf/dl-printf.c | 292 ++++++++++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 297 insertions(+), 278 deletions(-) >> create mode 100644 elf/dl-printf.c >> >> diff --git a/elf/Makefile b/elf/Makefile >> index b86d116be9..0c4be43deb 100644 >> --- a/elf/Makefile >> +++ b/elf/Makefile >> @@ -31,7 +31,7 @@ routines = $(all-dl-routines) dl-support dl-iteratephdr \ >> # The core dynamic linking functions are in libc for the static and >> # profiled libraries. >> dl-routines = $(addprefix dl-,load lookup object reloc deps \ >> - runtime init fini debug misc \ >> + runtime init fini debug misc printf \ >> version profile tls origin scope \ >> execstack open close trampoline \ >> exception sort-maps lookup-direct \ > > Should we put one item per-line now? And drop the addprefix? I can submit a separate patch for that. Thanks, Florian