From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 80213385C406 for ; Mon, 20 Dec 2021 13:32:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 80213385C406 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-540-xQagqK78M1C2KXQLq34vXw-1; Mon, 20 Dec 2021 08:32:58 -0500 X-MC-Unique: xQagqK78M1C2KXQLq34vXw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1E80E363A5; Mon, 20 Dec 2021 13:32:57 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.104]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D2AB412E21; Mon, 20 Dec 2021 13:32:55 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, John Mellor-Crummey , Ben Woodard Subject: Re: [PATCH v6 16/20] elf: Add main application on main_map l_name References: <20211115183734.531155-1-adhemerval.zanella@linaro.org> <20211115183734.531155-17-adhemerval.zanella@linaro.org> Date: Mon, 20 Dec 2021 14:32:53 +0100 In-Reply-To: <20211115183734.531155-17-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Mon, 15 Nov 2021 15:37:30 -0300") Message-ID: <87lf0fh056.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Dec 2021 13:33:00 -0000 * Adhemerval Zanella: > For the la_objopen() the path listed in link_map->l_name for the main > application binary is empty, even though dladdr() is able to recover the > correct path. > > By setting the expected application name on l_name, it allows to > simplify the code to handle the special case and make the API that > return such information (la_objopen(), dladdr() and dlinfo() to have > similar semantic. I would like to recommend skipping this patch for now, as discussed. At least "" is unambiguous, a real-looking path won't be because in some cases, we just can't provide an accurate path. Thanks, Florian