From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fweimer@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by sourceware.org (Postfix) with ESMTPS id 8F271385BC23
 for <libc-alpha@sourceware.org>; Wed, 10 Nov 2021 09:27:24 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8F271385BC23
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-277-gcc9NtksPlST2UWtNsLXlA-1; Wed, 10 Nov 2021 04:27:23 -0500
X-MC-Unique: gcc9NtksPlST2UWtNsLXlA-1
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com
 [10.5.11.12])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D0DD11006AA0;
 Wed, 10 Nov 2021 09:27:21 +0000 (UTC)
Received: from oldenburg.str.redhat.com (unknown [10.39.192.82])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id DBA4960C0F;
 Wed, 10 Nov 2021 09:27:20 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH v2] Support C2X printf %b, %B
References: <alpine.DEB.2.22.394.2110072315020.1855445@digraph.polyomino.org.uk>
 <alpine.DEB.2.22.394.2110130037060.1580815@digraph.polyomino.org.uk>
Date: Wed, 10 Nov 2021 10:27:18 +0100
In-Reply-To: <alpine.DEB.2.22.394.2110130037060.1580815@digraph.polyomino.org.uk>
 (Joseph Myers's message of "Wed, 13 Oct 2021 00:37:42 +0000")
Message-ID: <87lf1w743t.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW,
 RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Nov 2021 09:27:25 -0000

* Joseph Myers:

> +@item @samp{%b}, @samp{%B}
> +Print an integer as an unsigned binary number.  @samp{%b} uses
> +lower-case @samp{b} with the @samp{#} flag and @samp{%B} uses
> +upper-case.  @samp{%b} is an ISO C2X feature; @samp{%B} is an
> +extension recommended by ISO C2X.  @xref{Integer Conversions}, for
> +details.

The new tests do not contain any negative input numbers.  Do they result
in undefined behavior?

The code changes themselves look okay to me.

Thanks,
Florian