From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 219643857815 for ; Tue, 27 Jul 2021 16:36:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 219643857815 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-572-dNxuuRqOOk2kbYJtQBeQlA-1; Tue, 27 Jul 2021 12:36:53 -0400 X-MC-Unique: dNxuuRqOOk2kbYJtQBeQlA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8C344100E422; Tue, 27 Jul 2021 16:36:52 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-7.ams2.redhat.com [10.36.112.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B11DE1BCF0; Tue, 27 Jul 2021 16:36:51 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella via Libc-alpha Cc: Adhemerval Zanella , John Mellor-Crummey Subject: Re: [PATCH v2 1/6] elf: Fix audit regression References: <20210719143309.2848878-1-adhemerval.zanella@linaro.org> <20210719143309.2848878-2-adhemerval.zanella@linaro.org> Date: Tue, 27 Jul 2021 18:36:50 +0200 In-Reply-To: <20210719143309.2848878-2-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Mon, 19 Jul 2021 11:33:04 -0300") Message-ID: <87lf5rd87x.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jul 2021 16:36:56 -0000 * Adhemerval Zanella via Libc-alpha: > diff --git a/elf/dl-open.c b/elf/dl-open.c > index d2240d8747..218a8312a3 100644 > --- a/elf/dl-open.c > +++ b/elf/dl-open.c > @@ -770,15 +770,7 @@ dl_open_worker (void *a) > if (!args->libc_already_loaded) > { > struct link_map *libc_map = GL(dl_ns)[args->nsid].libc_map; > -#ifdef SHARED > - bool initial = libc_map->l_ns == LM_ID_BASE; > -#else > - /* In the static case, there is only one namespace, but it > - contains a secondary libc (the primary libc is statically > - linked). */ > - bool initial = false; > -#endif > - _dl_call_libc_early_init (libc_map, initial); > + _dl_call_libc_early_init (libc_map, false); > } > > /* Run the initializer functions of new objects. Temporarily Maybe add a comment that dlopen cannot be used to load an initial libc by design? Rest of the patch looks good to me. Thanks, Florian