From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 6/7] socket: Add recvmsg timestamp test
Date: Tue, 06 Jul 2021 16:50:22 +0200 [thread overview]
Message-ID: <87lf6jebtd.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <e072616e-004f-c369-8293-fadb8032bfeb@linaro.org> (Adhemerval Zanella's message of "Tue, 6 Jul 2021 09:55:10 -0300")
* Adhemerval Zanella:
> But this is also error prone (and I would consider that drivers using
> libc-define datatypes are as well) and I see your point. I would
> prefer if we avoid extra 64-bit symbols, but if you think we would
> improve support in the future we can add as a conservative way.
getsockopt/setsockopt is special because there is real length
information. We don't have that for fcntl, and only sort-of for ioctl.
So the kernel at least has a chance of doing the right thing for
getsockopt/setsockopt. And we don't need the time32-vs-time64
information in glibc for the present code because it's all encoded in
the option name. So getsockopt/setsockopt is definitely a corner case.
For recvmsg, sendmsg, sendmmsg, I think we need the time64 alias so that
we can disable the rewriting if it turns out to be too disruptive.
Thanks,
Florian
next prev parent reply other threads:[~2021-07-06 14:50 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 18:30 [PATCH 0/7] Linux 64-bit time_t socket fixes Adhemerval Zanella
2021-07-05 18:30 ` [PATCH 1/7] linux: Consolidate Linux getsockopt implementation Adhemerval Zanella
2021-07-05 18:58 ` Florian Weimer
2021-07-05 18:30 ` [PATCH 2/7] linux: Consolidate Linux setsockopt implementation Adhemerval Zanella
2021-07-05 18:59 ` Florian Weimer
2021-07-05 18:30 ` [PATCH 3/7] linux: Use the expected size for SO_TIMESTAMP{NS} convertion Adhemerval Zanella
2021-07-05 19:00 ` Florian Weimer
2021-07-06 13:06 ` Adhemerval Zanella
2021-07-05 18:30 ` [PATCH 4/7] linux: Fix setsockopt fallback Adhemerval Zanella
2021-07-05 19:07 ` Florian Weimer
2021-07-06 13:07 ` Adhemerval Zanella
2021-07-06 14:08 ` Florian Weimer
2021-07-05 18:30 ` [PATCH 5/7] support: Add support_socket_time64_timestamp Adhemerval Zanella
2021-07-05 18:46 ` Florian Weimer
2021-07-05 18:51 ` Adhemerval Zanella
2021-07-05 18:30 ` [PATCH 6/7] socket: Add recvmsg timestamp test Adhemerval Zanella
2021-07-05 19:32 ` Florian Weimer
2021-07-05 19:51 ` Adhemerval Zanella
2021-07-05 20:02 ` Florian Weimer
2021-07-05 20:35 ` Adhemerval Zanella
2021-07-06 9:29 ` Florian Weimer
2021-07-06 12:55 ` Adhemerval Zanella
2021-07-06 14:50 ` Florian Weimer [this message]
2021-07-05 18:30 ` [PATCH 7/7] socket: Add recvmmsg " Adhemerval Zanella
2021-07-05 19:12 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lf6jebtd.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=arnd@arndb.de \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).