From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 5F24B387740D for ; Mon, 28 Jun 2021 04:38:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5F24B387740D Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-502-8SFhL3M4Mn-w0S3g3RpdMw-1; Mon, 28 Jun 2021 00:38:06 -0400 X-MC-Unique: 8SFhL3M4Mn-w0S3g3RpdMw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7BBE7800D55; Mon, 28 Jun 2021 04:38:05 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-228.ams2.redhat.com [10.36.112.228]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AB61426E77; Mon, 28 Jun 2021 04:38:04 +0000 (UTC) From: Florian Weimer To: Siddhesh Poyarekar via Libc-alpha Cc: Siddhesh Poyarekar Subject: Re: [PATCH] Move tst-resolv-res_init-multi to xtests References: <20210622044449.4091104-1-siddhesh@sourceware.org> Date: Mon, 28 Jun 2021 06:38:02 +0200 In-Reply-To: <20210622044449.4091104-1-siddhesh@sourceware.org> (Siddhesh Poyarekar via Libc-alpha's message of "Tue, 22 Jun 2021 10:14:49 +0530") Message-ID: <87lf6uzjrp.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jun 2021 04:38:09 -0000 * Siddhesh Poyarekar via Libc-alpha: > Tests that need network access may cause false failures due to network > glitches because of which they are typically added as xtests. See for > example posix/tst-getaddrinfo{4,5}.c. Move tst-resolv-res_init-multi > also to xtests so that it is not executed in a regular test run. The comment in the test says that it does not matter whether the lookup succeeds. If this test fails, this could point to a real problem. Thanks, Florian