From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id BC5C03854814 for ; Tue, 16 Mar 2021 14:45:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BC5C03854814 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-61-MXGiRmR-PgagajVQSWLF2g-1; Tue, 16 Mar 2021 10:45:15 -0400 X-MC-Unique: MXGiRmR-PgagajVQSWLF2g-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2404F804B6C; Tue, 16 Mar 2021 14:45:14 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-254.ams2.redhat.com [10.36.112.254]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C38126F7F1; Tue, 16 Mar 2021 14:45:12 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 04/18] nptl: Move legacy cancelation handling into libc as compat symbols References: <1ece6f9349c307d5d81fe2ee319866c9c47254b8.1615569355.git.fweimer@redhat.com> <544c2f1f-0186-a000-066f-47f403e5c802@linaro.org> Date: Tue, 16 Mar 2021 15:45:21 +0100 In-Reply-To: <544c2f1f-0186-a000-066f-47f403e5c802@linaro.org> (Adhemerval Zanella's message of "Tue, 16 Mar 2021 11:09:19 -0300") Message-ID: <87lfannon2.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Mar 2021 14:45:22 -0000 * Adhemerval Zanella: >> diff --git a/nptl/Versions b/nptl/Versions >> index e3eb686a04..ff6eae2566 100644 >> --- a/nptl/Versions >> +++ b/nptl/Versions >> @@ -1,5 +1,9 @@ >> libc { >> GLIBC_2.0 { >> + _pthread_cleanup_pop; >> + _pthread_cleanup_pop_restore; >> + _pthread_cleanup_push; >> + _pthread_cleanup_push_defer; >> pthread_attr_destroy; >> pthread_attr_getdetachstate; >> pthread_attr_getinheritsched; >> @@ -103,6 +107,8 @@ libc { >> __pthread_attr_init; >> __pthread_attr_setaffinity_np; >> __pthread_attr_setsigmask_internal; >> + __pthread_cleanup_pop; >> + __pthread_cleanup_push; >> __pthread_cond_destroy; # Used by the C11 threads. >> __pthread_cond_init; # Used by the C11 threads. >> __pthread_force_elision; > > Why are you exporting the double underscore __pthread_cleanup_[pop,push] > on older versions here? More patch context: GLIBC_PRIVATE { __futex_abstimed_wait64; __futex_abstimed_wait_cancelable64; __libc_alloca_cutoff; __libc_allocate_rtsig_private; __libc_cleanup_pop_restore; __libc_cleanup_push_defer; __libc_current_sigrtmax_private; __libc_current_sigrtmin_private; __libc_dl_error_tsd; __libc_pthread_init; __lll_clocklock_elision; __lll_lock_elision; __lll_lock_wait; __lll_lock_wait_private; __lll_trylock_elision; __lll_unlock_elision; __pthread_attr_copy; __pthread_attr_destroy; __pthread_attr_init; __pthread_attr_setaffinity_np; __pthread_attr_setsigmask_internal; + __pthread_cleanup_pop; + __pthread_cleanup_push; __pthread_cond_destroy; # Used by the C11 threads. __pthread_cond_init; # Used by the C11 threads. __pthread_force_elision; __pthread_getattr_default_np; } I've added this to the commit message: __pthread_cleanup_pop and __pthread_cleanup_push are added as GLIBC_PRIVATE symbols because they are also used internally, for glibc's own cancellation handling. Thanks, Florian