public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Replaced obsoleted AC_HELP_STRING to AS_HELP_STRING
Date: Mon, 15 Feb 2021 18:17:35 +0100	[thread overview]
Message-ID: <87lfbp5jyo.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <e7bdbe12-470b-45f1-d96d-212d78d6e279@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Mon, 15 Feb 2021 13:39:01 -0300")

* Adhemerval Zanella via Libc-alpha:

> Again, I don't have a strong opinion about it so I not following your
> slight aggressive tone here.  I just initially asked *why* change it,
> since we already have a specific check for the version so any version
> migration would require to check if these macros indeed would break
> something (and I agree with you that this would make easier to upgrade).

I must say I find it odd that we build with -Werror, try to address all
kinds of compiler warnings, and then push back against fixing warnings
in other places.

If it's possible to get rid of the warning while retaining compatibility
with 2.69 for the time being, then let's do it?

Thanks,
Florian
-- 
Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill


  reply	other threads:[~2021-02-15 17:17 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-15 12:31 Naohiro Tamura
2021-02-15 12:59 ` Adhemerval Zanella
2021-02-15 13:29   ` Mike Frysinger
2021-02-15 13:39     ` Adhemerval Zanella
2021-02-15 15:38       ` Mike Frysinger
2021-02-15 16:39         ` Adhemerval Zanella
2021-02-15 17:17           ` Florian Weimer [this message]
2021-02-15 18:51             ` Adhemerval Zanella
2021-02-15 20:21           ` Mike Frysinger
2021-02-15 20:31             ` Adhemerval Zanella
2021-02-16  2:36               ` naohirot
2021-02-16 12:01 ` [PATCH 3/3] Removed obsolete AC_CHECK_TOOL_PREFIX Naohiro Tamura
2021-02-16 16:41   ` Zack Weinberg
2021-02-17  1:25     ` naohirot
2021-02-21 23:36   ` Mike Frysinger
2021-02-22  1:48     ` naohirot
2021-02-21 21:31 ` [PATCH] Replaced obsoleted AC_HELP_STRING to AS_HELP_STRING Mike Frysinger
2021-02-22  1:41   ` naohirot
2021-02-23  2:02   ` Carlos O'Donell
2021-05-10  0:52     ` naohirot
2021-05-10  1:17       ` Mike Frysinger
2021-05-10  2:15         ` naohirot
2021-05-10 14:16           ` naohirot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfbp5jyo.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).