From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 6D65B385ED4A for ; Mon, 15 Feb 2021 17:17:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6D65B385ED4A Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-332-scgk_QRQOga8fNnmV-l3Jg-1; Mon, 15 Feb 2021 12:17:10 -0500 X-MC-Unique: scgk_QRQOga8fNnmV-l3Jg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 12E08100CC86; Mon, 15 Feb 2021 17:17:09 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-113-131.ams2.redhat.com [10.36.113.131]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C7B1519D9F; Mon, 15 Feb 2021 17:17:07 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH] Replaced obsoleted AC_HELP_STRING to AS_HELP_STRING References: <20210215123137.204048-1-naohirot@fujitsu.com> <0820aeae-41c4-e751-e6b2-aaa83921fc41@linaro.org> <060cf851-b2c9-a608-7dbb-7f7a4636ea6a@linaro.org> Date: Mon, 15 Feb 2021 18:17:35 +0100 In-Reply-To: (Adhemerval Zanella via Libc-alpha's message of "Mon, 15 Feb 2021 13:39:01 -0300") Message-ID: <87lfbp5jyo.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2021 17:17:14 -0000 * Adhemerval Zanella via Libc-alpha: > Again, I don't have a strong opinion about it so I not following your > slight aggressive tone here. I just initially asked *why* change it, > since we already have a specific check for the version so any version > migration would require to check if these macros indeed would break > something (and I agree with you that this would make easier to upgrade). I must say I find it odd that we build with -Werror, try to address all kinds of compiler warnings, and then push back against fixing warnings in other places. If it's possible to get rid of the warning while retaining compatibility with 2.69 for the time being, then let's do it? Thanks, Florian -- Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill