From: Florian Weimer <fweimer@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Subject: Re: V3 [PATCH] <sys/platform/x86.h>: Remove the C preprocessor magic
Date: Thu, 21 Jan 2021 12:19:40 +0100 [thread overview]
Message-ID: <87lfcmzgdv.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <CAMe9rOqVRGrjkms6VM1V0gYs7Ty7b8guqK9HE5T63bg389OFYA@mail.gmail.com> (H. J. Lu's message of "Wed, 20 Jan 2021 16:19:14 -0800")
* H. J. Lu:
> Here is the updated patch. The public function is changed to
>
> /* Get a pointer to the CPU feature structure. */
> extern const struct cpuid_feature *__x86_get_cpuid_feature_leaf (unsigned int)
> __attribute__ ((pure));
>
> OK for master?
Are you okay with this version? I like the simplicity of the interface.
Can we move the GLIBC_2.33 symbol into libc.so.6? It will be very
unusual for an object not to be linked against libc.so.6, so I expect
that the IFUNC resolver already won't run until after libc.so.6
relocation (due to the relocation ordering check we have on x86).
Thanks,
Florian
--
Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill
next prev parent reply other threads:[~2021-01-21 11:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-25 16:24 H.J. Lu
2021-01-20 9:53 ` Florian Weimer
2021-01-20 11:23 ` Florian Weimer
2021-01-20 14:43 ` V2 " H.J. Lu
2021-01-20 15:58 ` Florian Weimer
2021-01-21 0:19 ` V3 " H.J. Lu
2021-01-21 11:19 ` Florian Weimer [this message]
2021-01-21 13:29 ` V4 " H.J. Lu
2021-01-21 13:57 ` Florian Weimer
2021-01-21 14:12 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfcmzgdv.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).