From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 2AC0A384B0C1 for ; Mon, 14 Dec 2020 22:17:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2AC0A384B0C1 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-181-ph-c0gIKO6605nldkWCidw-1; Mon, 14 Dec 2020 17:17:00 -0500 X-MC-Unique: ph-c0gIKO6605nldkWCidw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B7A00801817; Mon, 14 Dec 2020 22:16:59 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-112-228.ams2.redhat.com [10.36.112.228]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 12E7B5D9DC; Mon, 14 Dec 2020 22:16:58 +0000 (UTC) From: Florian Weimer To: Martin Sebor Cc: GNU C Library Subject: Re: [PATCH] add support for -Wmismatched-dealloc References: <74efece7-9a4b-83ee-7fdd-475c0d514378@gmail.com> <758e723b-67cf-a211-7bc2-2ccd3fc744e5@gmail.com> Date: Mon, 14 Dec 2020 23:16:57 +0100 In-Reply-To: <758e723b-67cf-a211-7bc2-2ccd3fc744e5@gmail.com> (Martin Sebor's message of "Mon, 14 Dec 2020 14:39:56 -0700") Message-ID: <87lfe09go6.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Dec 2020 22:17:05 -0000 * Martin Sebor: > Florian asked this morning if getaddrinfo() and freeaddrinfo() are > covered by this change. They're not because getaddrinfo() returns > the allocated memory indirectly, via an argument. To handle those > kinds of APIs that return a pointer to the allocated object > indirectly, through an argument, the attribute will need to be > enhanced somehow. asprintf is another such function, perhaps slightly more commonly used. It would be nice if this interface pattern could be covered as well. Thanks, Florian -- Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill