From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 1306A3854802 for ; Fri, 9 Oct 2020 09:06:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1306A3854802 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-554-pPj1N1RUOdCT28JoamiQsQ-1; Fri, 09 Oct 2020 05:06:07 -0400 X-MC-Unique: pPj1N1RUOdCT28JoamiQsQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E55E0101FFA2; Fri, 9 Oct 2020 09:06:06 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-113-154.ams2.redhat.com [10.36.113.154]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3CE3F50B44; Fri, 9 Oct 2020 09:06:06 +0000 (UTC) From: Florian Weimer To: "Paul A. Clarke via Libc-alpha" Cc: "Paul A. Clarke" Subject: Re: [PATCH 18/28] powerpc64le: Add glibc-hwcaps support References: <01faff4932d02c7e3224b50a1cdb5956354b1fc2.1601569371.git.fweimer@redhat.com> <20201001185639.GA132840@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com> <87ft6txavf.fsf@oldenburg2.str.redhat.com> <20201005191500.GA69013@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com> <87y2kjsfzu.fsf@oldenburg2.str.redhat.com> <20201006174519.GB105796@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com> Date: Fri, 09 Oct 2020 11:06:04 +0200 In-Reply-To: <20201006174519.GB105796@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com> (Paul A. Clarke via Libc-alpha's message of "Tue, 6 Oct 2020 12:45:19 -0500") Message-ID: <87lfgfdb0j.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Oct 2020 09:06:11 -0000 * Paul A. Clarke via Libc-alpha: > Ah, so you are trying to model the "hwcaps subdirs" on the command-line > argument. The latter has to be split to be used, why not allow the > subdirs to be "pre-split", then both could be handled as an array > of strings? The array for the subdirs could be pre-allocated (if it will > always be less than 32 entries) and filled in directly > during "active" processing, obviating the need for the mysterious > and ephemeral bits indicating "use this"/"don't use this". Splitting the strings will need memory allocation and all that. It may look more familiar, but I don't think it's going to be simpler. For the --help diagnostic, we also need information on all potentially supported (but inactive) subdirectory strings. So something that computes a single array would not be sufficient. I'll see if I can cut down on the magic numbers by other means. Thanks, Florian -- Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill